myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Lessard (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-712) Do not generate final properties with the maven-faces-plugin
Date Sun, 16 Sep 2007 19:56:32 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527897
] 

Simon Lessard commented on TRINIDAD-712:
----------------------------------------

However, there's something to keep in mind even if final is not there. Renderers use direct
read in the bean object, making simple accessors override override insufficient to completely
hook all accesses to any given property, so I guess that's an argument in favor of final to
not give false perceptions to users.

> Do not generate final properties with the maven-faces-plugin
> ------------------------------------------------------------
>
>                 Key: TRINIDAD-712
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-712
>             Project: MyFaces Trinidad
>          Issue Type: Wish
>          Components: Plugins
>    Affects Versions: 1.0.2-plugins
>         Environment: maven-faces-plugin version 1.0.2 from the maven repository
>            Reporter: Andrew Robinson
>            Assignee: Adam Winer
>
> It would be extremely beneficial to not have property methods generated as final by the
maven-faces-plugin. 
> IMO, final should be reserved for constants and only on methods with rare exceptions
and good reasons.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message