Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 58455 invoked from network); 23 Aug 2007 13:04:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Aug 2007 13:04:54 -0000 Received: (qmail 63801 invoked by uid 500); 23 Aug 2007 13:04:50 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 63748 invoked by uid 500); 23 Aug 2007 13:04:50 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 63737 invoked by uid 99); 23 Aug 2007 13:04:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2007 06:04:50 -0700 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Aug 2007 13:05:31 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D150071420C for ; Thu, 23 Aug 2007 06:04:30 -0700 (PDT) Message-ID: <28946483.1187874270854.JavaMail.jira@brutus> Date: Thu, 23 Aug 2007 06:04:30 -0700 (PDT) From: "Paul Pogonyshev (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Updated: (TOMAHAWK-902) Bug in DefaultAddResource. Resources added AddResource.BODY_END are rendered in the page header In-Reply-To: <869364.1171839485699.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TOMAHAWK-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Pogonyshev updated TOMAHAWK-902: ------------------------------------- Status: Patch Available (was: Open) > Bug in DefaultAddResource. Resources added AddResource.BODY_END are rendered in the page header > ----------------------------------------------------------------------------------------------- > > Key: TOMAHAWK-902 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-902 > Project: MyFaces Tomahawk > Issue Type: Bug > Components: ExtensionsFilter > Affects Versions: 1.1.3 > Reporter: David Turner > > Resources added with a position of AddResource.BODY_END are rendered in the page header not at body end. > In DefaultAddResource.writeWithFullHeader:724: > if (afterBodyContentInsertPosition >= 0) > { > ... > originalResponse.insert(headerInsertPosition, writerWrapper.toString()); > } > Shouldn't this be: > if (afterBodyContentInsertPosition >= 0) > { > ... > originalResponse.insert(afterBodyContentInsertPosition, writerWrapper.toString()); > } > Workaround: > Write your own AddResource implementation (just copy the DefaultAddResource); include this fix; override default in web.xml with: > > org.apache.myfaces.ADD_RESOURCE_CLASS > au.com.project.common.ui.renderkit.html.util.DefaultAddResource > Override default resource handler (extensions filter) > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.