myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer" <awi...@gmail.com>
Subject Re: TRINIDAD : Trinidad - 85 : Adam's Comments - question
Date Fri, 03 Aug 2007 17:39:57 GMT
The naming pattern we've used would look more like:
-adfinternal-onclickOnImgInput

-- Adam


On 8/3/07, Piyush Hari <piyush.hari@oracle.com> wrote:
> Am I allowed to name for this capability ? Basically, my capability is
> testing if "onclick" is supported on "input" element of type "img"  ?
>
> How about : something like this :
>
> <capability name="-adfinternal-onclick-input-img" value="false"/>
>
> Are you ok with this name ?
>
> -Piyush
>
>
> Adam Winer wrote:
> > We should have an agent capability flag for this.
> > See the files in trinidad-impl/src/main/resources/META-INF/agents
> > as well as org.apache.myfaces.trinidadinternal.agent.TrinidadAgent.
> >
> > The problem with "isPDA()" is that we've lost all context
> > for what feature is really relevant, and no decent way to indicate
> > that some PDA might in fact support the feature, either now
> > or in the future.
> >
> > -- Adam
> >
> >
> > On 8/2/07, Piyush Hari <piyush.hari@oracle.com> wrote:
> >
> >> Adam,
> >>
> >> You commented the following on my patch for TRINIDAD - 85
> >> https://issues.apache.org/jira/browse/TRINIDAD-85 :
> >>
> >> /"I'm not fond of the isPDA() check. Please add an agent flag, defaulting
> >> to true, and set it to false for the relevant platforms. I also see a lot
> >> of non-two-space whitespace here."
> >>
> >> /Can you elaborate a bit more on what you are recommending ?  What do
> >> you mean by an agent flag ?
> >>
> >> Thanks,
> >> -Piyush
> >>
> >>
>
>

Mime
View raw message