myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Lessard" <simon.lessar...@gmail.com>
Subject Re: [Trinidad] Skining - strange default value in: base-desktop.xss
Date Sat, 11 Aug 2007 21:57:51 GMT
Well even if I did make that note, I never had any problem inhibiting
properties from simple skin. Are you trying to set a skin using
skin-extension maybe? If so, that,s your problem.

On 8/11/07, Cristi Toth <cristi.toth@gmail.com> wrote:
>
> the thing is that the order in which the nodes are handled is very
> important
>
> the base skin style-sheet should be the first
> and the custom style-sheet should be the last
> this way any property inhibit or override should work as needed
>
> it's useless to load all the properties and then apply the tr-inhibit
> because my property will still be overwritten by that in the base-skin
> and the tr-inhibit will inhibit ANY property definition
>
> the big problem is in the order the style-sheets are handled
>
> regards,
> Cristi Toth
>
> -------------
> Codebeat
> www.codebeat.ro
>
> On 8/11/07, Simon Lessard <simon.lessard.3@gmail.com> wrote:
> >
> > Yeah I remember that comment that I put there. I'll check it again, see
> > what would be the impact of loading everything before doing inhibit and
> > probably fill a JIRA issue about this.
> >
> >
> > ~ Simon
> >
> > On 8/11/07, Cristi Toth <cristi.toth@gmail.com> wrote:
> > >
> > > Hi Simon,
> > >
> > > I know the "-tr-inhibit" property,
> > > BUT the base skin style-sheet seems to be added last
> > > so the nodes form it always override the nodes in me style-sheet
> > > even if I use -tr-inhibit
> > >
> > > This is exactly what you said in the code I mentioned before.
> > > You never know which one has the priority :(
> > >
> > > regards,
> > > Cristi Toth
> > >
> > > -------------
> > > Codebeat
> > > www.codebeat.ro
> > >
> > >
> > > On 8/10/07, Simon Lessard < simon.lessard.3@gmail.com> wrote:
> > > >
> > > > Hello Cristi,
> > > >
> > > > I had that discussion a while back during incubation. I would also
> > > > like a very light (empty) base skin and we're actually going to make one
for
> > > > a project. It's already possible by extending simple, overriding every
> > > > single selectors and add a "-tr-inhibit: all;", effectively disabling
all
> > > > aliases as well. I do think many users could like to have such a skin
to
> > > > extend from and I'm going to ask the project manager to donate the empty
> > > > skin once it's done.
> > > >
> > > >
> > > > Regards,
> > > >
> > > > ~ Simon
> > > >
> > > > On 8/9/07, Cristi Toth < cristi.toth@gmail.com> wrote:
> > > > >
> > > > > Ok... I thought that using a skin that extends no base skin or a
> > > > > very basic (empty) one would do the trick
> > > > > But I found out that the most basic one is the SimpleDesktopSkin
> > > > > which includes that huge base-desktop.xss
> > > > >
> > > > > I can understand that it is ok to have a good default skin
> > > > > But shouldn't it be a way to just use an EMPTY BASE SKIN ?
> > > > >
> > > > > Regards,
> > > > > Cristi Toth
> > > > >
> > > > > Codebeat
> > > > > www.codebeat.ro
> > > > >
> > > > > On 8/10/07, Cristi Toth <cristi.toth@gmail.com > wrote:
> > > > > >
> > > > > > My problem is even bigger :(
> > > > > > as Simon Lessard already noticed in StyleSheetDocument, on line
> > > > > > 477
> > > > > > the method: private StyleNode _resolveStyle(...)  is really
> > > > > > buggy
> > > > > >
> > > > > > The problem is that it takes all the style definitions of a
> > > > > > selector / element in a 'random' order
> > > > > > and the properties in the first instances are being overwritten
> > > > > > by the same properties from the later instances
> > > > > > This is not good...
> > > > > > At least it would have been ... ok, if the definitions from
the
> > > > > > skin extension style-sheet would have been last
> > > > > > but in my example, the base-desktop.xss seems to be last,
> > > > > > so even if I inhibit the annoying { margin-top: 8px }  property
> > > > > > in the skin,
> > > > > > it is still overwritten by the instance in base-desktop.xss,
> > > > > > which is last (so it has greater priority)
> > > > > >
> > > > > > This is serious trouble
> > > > > > and I don't know how to override this behavior in my current
> > > > > > project! (I can't wait for a snapshot fix)
> > > > > > Can anybody suggest some solution?
> > > > > >
> > > > > > Is there an issue on this problem ?
> > > > > >
> > > > > > thanks,
> > > > > > Cristi Toth
> > > > > >
> > > > > > -------------
> > > > > > Codebeat
> > > > > > www.codebeat.ro
> > > > > >
> > > > > >
> > > > > > On 8/10/07, Cristi Toth <cristi.toth@gmail.com> wrote:
> > > > > > >
> > > > > > > Hi!
> > > > > > >
> > > > > > > I found a strange default value for IE browser: body {
> > > > > > > margin-top: 8px } in base-desktop.xss
> > > > > > > on line 3943:
> > > > > > >
> > > > > > > <styleSheet browsers="ie">
> > > > > > >
> > > > > > >   <style selector="body">
> > > > > > >     <property name="margin-top">8px</property>
> > > > > > >   </style>
> > > > > > > ...
> > > > > > >
> > > > > > > Why on earth would anybody need this setting?
> > > > > > >
> > > > > > > I lost some valuable time on finding this...
> > > > > > > And its effect was really annoying!
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Cristi Toth
> > > > > > > -------------
> > > > > > > Codebeat
> > > > > > > www.codebeat.ro
> > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Cristi Toth
> > > > > -------------
> > > > > Codebeat
> > > > > www.codebeat.ro
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Cristi Toth
> > > -------------
> > > Codebeat
> > > www.codebeat.ro
> > >
> >
> >
>
>
> --
> Cristi Toth
>
> -------------
> Codebeat
> www.codebeat.ro
>

Mime
View raw message