myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From simon <skitch...@apache.org>
Subject Re: [orchestra] servlet filters ..
Date Sat, 18 Aug 2007 13:31:41 GMT
On Sat, 2007-08-18 at 14:24 +0200, Mario Ivankovits wrote:
> Hi!
> >> The only advantage of the current way (servlet filter) is, that it works
> >> in an mixed webapp environment (JSF/JSP)
> >> However, we can provide your's as the default and provide mine as an
> >> alternative if we would like to.
> >>     
> >
> > jo, that's why I think the "framework-adapter" might be fine in a filter ?!
> >   
> I don't understand the question.
> You asked about the RequestParameterResponseWrapper.
> 
> The Framework-Adapter is another story.
> I had the need to access the request/session map outside of an already
> setup facesContext.
> The JsfFrameworkAdapter already depends on the OrchestraServletFilter
> where we setup two thread-locals to get access to the request/response
> object outside of a ready setup Faces-Context, which is required right
> in the OrchestraServletFilter.
> So I am fine by adding some Framework-Adapter specified stuff to the
> OrchestraServletFilter - instead of creating a new filter.

Ok, I've created a patch for review.

My stupid email client wraps lines at 80 chars, so I've attached it
instead of providing it inline.

Regards,

Simon

Mime
View raw message