myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matthias Weßendorf (JIRA) <...@myfaces.apache.org>
Subject [jira] Updated: (MYFACES-1681) UIComponent.getAttributes() too restrictive
Date Thu, 19 Jul 2007 11:31:08 GMT

     [ https://issues.apache.org/jira/browse/MYFACES-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Matthias Weßendorf updated MYFACES-1681:
----------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.1-SNAPSHOT
           Status: Resolved  (was: Patch Available)

Hey Ryan,

thanks for pointing this out.
This is 100% same code as in MyFaces 1.1.x.
So should we address this in JSF 1.1 as well ?

> UIComponent.getAttributes() too restrictive
> -------------------------------------------
>
>                 Key: MYFACES-1681
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1681
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: JSR-252
>    Affects Versions:  1.2.0
>         Environment: SE 1.6.0_02
> GlassFish V2 admingui
>            Reporter: Ryan Lubke
>            Assignee: Matthias Weßendorf
>             Fix For: 1.2.1-SNAPSHOT
>
>         Attachments: MYFACES-1681.patch
>
>
> The Map returned by UIComponent.getAttributes() is too restrictive with respect
> to null values.
> MyFaces will always throw an NPE for a null value.  Granted, the following is
> in the javadocs:
>  * Any attempt to add a null key or value must throw a NullPointerException.
> However, the following is also in the same section:
>  * put() - If the property is writeable, call the setter method to set the corresponding
value (unwrapping primitive values in their    
>    corresponding wrapper classes). If the property is not writeable, or an attempt is
made to set a property of primitive type to null, throw 
>    IllegalArgumentException.
> Notice the comment about setting a primitive property to null.  This implies that a null
value for this case
> is legal.  The RI will only throw the NPE against a null value *if* there isn't an associated
property.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message