myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zdenek Sochor (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOMAHAWK-1012) TabbedPane does not validate non-selected tabs in server side tab switching mode
Date Mon, 11 Jun 2007 12:12:26 GMT

    [ https://issues.apache.org/jira/browse/TOMAHAWK-1012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503379
] 

Zdenek Sochor commented on TOMAHAWK-1012:
-----------------------------------------

Hi,
I played with the patch and my notes:

1. required components - i meant in all tabs, not just current/first visited tab, but that's
connected to:

2. Component tree made by TabbedPane consists only of tabs previously visited (and only for
those being rendered). This means that components in all subsequent tabs (even with processValidators=true)
are NOT checked.
This is due to internal checks of contents-rendering (not rendering/visiting childs of invisible
tabs).

If you want to have full validation of even yet unvisited (render-wise) components you would
need to:
a) traverse all posible components regardless of isRendered() checks, but this would mean
to 
b) rewrite all composite components in Tomahawk. (All of them create component tree based
on rendering being true).

But with comment regarding backward compatibily you're right, it's preserved.

And i'm sorry, user's selecting tab is correct (provided that it hasn't onclick method which
submits as i had with first test page)

With regards,
Zdenek

> TabbedPane does not validate non-selected tabs in server side tab switching mode
> --------------------------------------------------------------------------------
>
>                 Key: TOMAHAWK-1012
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1012
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Tabbed Pane
>    Affects Versions: 1.1.5, 1.1.6-SNAPSHOT
>            Reporter: David Delbecq
>         Attachments: tabbedPaneValidator.diff
>
>
> When your form spreads accross a tabbed pane, the validators of components residing inside
not selected tab are not validated. This is a problem because all form need to be validated
before writting values to backing beans.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message