Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <4616338.1179497417190.JavaMail.jira@brutus>
Date: Fri, 18 May 2007 07:10:17 -0700 (PDT)
From: "Cagatay Civici (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Resolved: (TOMAHAWK-979) ExcelExport - correct name for the
 downloaded file
In-Reply-To: <25943515.1178575275542.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/TOMAHAWK-979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cagatay Civici resolved TOMAHAWK-979.
-------------------------------------

       Resolution: Fixed
    Fix Version/s:     (was: 1.1.5)
                   1.1.6-SNAPSHOT

Although I always get the open/save dialog without the Content-disposition, it's good to ensure it. The fix is checked in.

> ExcelExport - correct name for the downloaded file
> --------------------------------------------------
>
>                 Key: TOMAHAWK-979
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-979
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>    Affects Versions: 1.1.5
>         Environment: Suse Linux 10.0 - with Firefox 1.5.0.10
>            Reporter: Emil Cazacu
>         Assigned To: Cagatay Civici
>            Priority: Minor
>             Fix For: 1.1.6-SNAPSHOT
>
>
> I started from the example presented in the public site.
> I click on the button, a new page is poped, then that page is blank.
> Without knowing what happened, the file is saved in the background where it usualy saves the downloaded files.
> I come with a correction for the class ExcelExportPhaseListener
>   private void writeExcelOutput(
>       HSSFWorkbook workBook,
>       HttpServletResponse response,
>       HtmlDataTable dataTable) throws IOException {
>     response.setContentType("application/vnd.ms-excel");
>     response.setHeader("Expires", "0");
>     response.setHeader("Cache-Control", "must-revalidate, post-check=0, pre-check=0");
>     response.setHeader("Pragma", "public");
>     response.setHeader("Content-disposition", "attachment;filename=" + dataTable.getId() + ".xls");
>     workBook.write(response.getOutputStream());
>   }
> Changes in behavior:
> - the downloaded file is named using the id of the component prefixed with .xls
> - a popup is presented to allow us between the options "run / save as"
> Changes in code:
> - the headers, very important being the "Content-disposition"
> - the number of the arguments is changed.
> I have previous experience with downloading excel file but using servlets.
> I am using JSF but writing JSF exceeds my knowledge.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.