Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 89356 invoked from network); 18 May 2007 04:45:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 May 2007 04:45:36 -0000 Received: (qmail 26003 invoked by uid 500); 18 May 2007 04:45:41 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 25579 invoked by uid 500); 18 May 2007 04:45:40 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 25568 invoked by uid 99); 18 May 2007 04:45:40 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2007 21:45:40 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [209.85.132.244] (HELO an-out-0708.google.com) (209.85.132.244) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 17 May 2007 21:45:33 -0700 Received: by an-out-0708.google.com with SMTP id c17so232281anc for ; Thu, 17 May 2007 21:45:12 -0700 (PDT) Received: by 10.100.153.17 with SMTP id a17mr826826ane.1179463512399; Thu, 17 May 2007 21:45:12 -0700 (PDT) Received: by 10.100.41.2 with HTTP; Thu, 17 May 2007 21:45:12 -0700 (PDT) Message-ID: <446564320705172145t76f661e5n8f1f503dd53276a3@mail.gmail.com> Date: Thu, 17 May 2007 22:45:12 -0600 From: "Dennis Byrne" To: "MyFaces Development" Subject: Re: Permission to upgrade shale-test v1.1.0-SNAPSHOT to allows for testing against the RI? In-Reply-To: <464D18D6.4030609@apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_56111_20376803.1179463512160" References: <464D18D6.4030609@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_56111_20376803.1179463512160 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline I'm 0 on this. The only warning I have is that we have to make sure the next version of Shale test is out before we release the next version of Tomahawk. If you think it is realistic, go for it. Dennis Byrne On 5/17/07, Paul Spencer wrote: > > I would like to add more Shale Test based tests to Tomahawk and do it in > such > a way that allows tests to be run against different JSF implementations, > including > the RI and MyFaces. In order to do this, the ConfigParser()[1] of > shale-test v1.1.0-SNAPSHOT is required. We are already using shale-test > v1.0.3. > > Although I an not keen on adding a SNAPSHOT dependency, this is one that > is used > only by some of the test cases. The major advantages in using the > ConfigParser() > is that the implementation's configuration files are used. I created an > utility, > TestUtils.addDefaultRenderers() [2], that manually add Tomahawks > configuration. > TestUtils currently works for Tomahawks components, since it manually add > the > configuration, it has to be maintained in parallel with faces-config.xml. > In > addition it does not work with other implementation. This utility class > would > be changed to reference ConfigParser(), not the tests. > > In short, I am asking for: > 1) Permission to upgrade shale-test v1.1.0-SNAPSHOT. > 2) Permission to add a continuum build of Tomahawk against the RI > > Paul Spencer > > > > [1]http://shale.apache.org/shale-test/apidocs/org/apache/shale/test/config/ConfigParser.html > > [2]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/utils/TestUtils.java?view=markup > -- Dennis Byrne ------=_Part_56111_20376803.1179463512160 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline I'm 0 on this.  The only warning I have is that we have to make sure the next version of Shale test is out before we release the next version of Tomahawk.  If you think it is realistic, go for it.

Dennis Byrne

On 5/17/07, Paul Spencer <paulsp@apache.org> wrote:
I would like to add more Shale Test based tests to Tomahawk and do it in such
a way that allows tests to be run against different JSF implementations, including
the RI and MyFaces.  In order to do this, the ConfigParser()[1] of
shale-test v1.1.0-SNAPSHOT is required.  We are already using shale-test v1.0.3.

Although I an not keen on adding a SNAPSHOT dependency, this is one that is used
only by some of the test cases.  The major advantages in using the ConfigParser()
is that the implementation's configuration files are used.  I created an utility,
TestUtils.addDefaultRenderers() [2], that manually add Tomahawks configuration.
TestUtils currently works for Tomahawks components, since it manually add the
configuration, it has to be maintained in parallel with faces-config.xml. In
addition it does not work with other implementation.  This utility class would
be changed to reference ConfigParser(), not the tests.

In short, I am asking for:
1) Permission to upgrade shale-test v1.1.0-SNAPSHOT.
2) Permission to add a continuum build of Tomahawk against the RI

Paul Spencer


[1]http://shale.apache.org/shale-test/apidocs/org/apache/shale/test/config/ConfigParser.html
[2]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/utils/TestUtils.java?view=markup



--
Dennis Byrne ------=_Part_56111_20376803.1179463512160--