myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jeanne Waldman (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TRINIDAD-23) goButton on PDAs should be rendererd as a linked button and not a button
Date Wed, 23 May 2007 23:00:19 GMT

    [ https://issues.apache.org/jira/browse/TRINIDAD-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498420
] 

Jeanne Waldman commented on TRINIDAD-23:
----------------------------------------

I sent Piyush a few code review comments, so we need a new patch.
1. make buttonInputOrLink private
2. boolean useButtonTag = useButtonTags(arc); is not being used (you call useButtonTags again)
3. use constants for Button, input, a
4. use .equals to string compare

> goButton on PDAs should be rendererd as a linked button and not a button
> ------------------------------------------------------------------------
>
>                 Key: TRINIDAD-23
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-23
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>         Environment: PDAs
>            Reporter: Piyush Hari
>            Priority: Minor
>         Attachments: patch_may17_goButton.patch, patch_may17_goButton.patch, patch_may17_goButton_pda.patch
>
>
> At present the following logic in GoButtonRenderer renders a goButton as a LINK (html
'a' tag) on PDAs because they don't support button tag :
>  
> String element = useButtonTag ? "button" : "a";
>  
> PDAs don't support <buttons> but support <input type="buttons"> . So, use
<input> instead of <a> for PDAs

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message