myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Winer (JIRA)" <>
Subject [jira] Updated: (MYFACES-1467) Validation doesn't run for required fields if submitted value is null
Date Tue, 24 Apr 2007 18:28:16 GMT


Adam Winer updated MYFACES-1467:

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

There is no conflict in the spec.  It is a Renderer's responsibility to only call setSubmittedValue(null)
 when there is truly no submission - disabled=true, readonly=true, etc.  Otherwise, it must
call setSubmittedValue() with something non-null.  It is free to convert that submitted value
back to null later in getConvertedValue().  A Renderer that copies getRequestParameterMap().get()
over to submitted value without checking for null has a bug.

> Validation doesn't run for required fields if submitted value is null
> ---------------------------------------------------------------------
>                 Key: MYFACES-1467
>                 URL:
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 1.1.5-SNAPSHOT, 1.2.0-SNAPSHOT
>            Reporter: David Chandler
>         Assigned To: Matthias We├čendorf
>             Fix For:  1.1.6-SNAPSHOT
>         Attachments: patch.txt, patch2.txt
> A component with a required value will not fail validation as expected if the submitted
value is null. This issue is not seen normally because browsers send the value for an empty
text field as an empty string. That is, the POST data for an empty field1 will contain the
field name but no value, like field1=&field2=something. However, if you use a man-in-the-middle
proxy such as Paros to remove "fieldname=" from the POST data, the submitted value will be
null. UIInput.validate() skips validation for null submitted values, but since requiredness
is also part of validation, the requiredness check gets skipped, too.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message