Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <4222852.1173440904247.JavaMail.root@brutus>
Date: Fri, 9 Mar 2007 03:48:24 -0800 (PST)
From: =?utf-8?Q?Josu=C3=A9_Alcalde_=28JIRA=29?= <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Created: (TOMAHAWK-927) Using t:commandSortHeader without
 propertyName will always result in a warning
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Using t:commandSortHeader without propertyName will always result in a warn=
ing
---------------------------------------------------------------------------=
---

                 Key: TOMAHAWK-927
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-927
             Project: MyFaces Tomahawk
          Issue Type: Bug
    Affects Versions: 1.1.5-SNAPSHOT
            Reporter: Josu=C3=A9 Alcalde
            Priority: Trivial


If someone use t:commandSortHeader and wants to implement sorting in his wa=
y, then he won't need to use propertyName in commandSortHeader.
Since I move to 1.1.5-SNAPSHOT this will result in a warning because of thi=
s code:

 else if (headerFacet instanceof HtmlCommandSortHeader)
                {
                    //command sort headers are already in place, just store=
 the column name and sort property name
                    HtmlCommandSortHeader sortHeader =3D (HtmlCommandSortHe=
ader) headerFacet;
                    columnName =3D sortHeader.getColumnName();
                    propertyName =3D sortHeader.getPropertyName();

                    //if the command sort header component doesn't specify =
a sort property, determine it
                    if (propertyName =3D=3D null)
                    {
                        propertyName =3D getSortPropertyFromEL(aColumn);
                        sortHeader.setPropertyName(propertyName);
                    }

                    if (propertyName =3D=3D null)
                        log.warn("Couldn't determine sort property for colu=
mn [" + aColumn.getId() + "].");
                }


I think the log.warn should be a log.debug, because it will warn innecesary=
 when you don't want to use the auto sorting.

Setting the propertyName to a fake value is a workaround.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.