myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Spencer <pau...@apache.org>
Subject Re: Question regarding adding a new verification task
Date Tue, 06 Feb 2007 14:13:46 GMT
IMHO Tomahawk should NOT require the sandbox tld passes the test, thus
1) do not uncomment the line
2) do remove the TODO
3) Configure tomahawk's maven to create at test jar
4) Configure sandbox's maven to use tomahawk's test jar.
5) Create an sandbox test that extends AbstractTagLibTestCase

Please wait until after the 1.1.5 release to do this!

Paul Spencer

[1]http://maven.apache.org/guides/mini/guide-attached-tests.html

Dennis Byrne wrote:
> When it came time to commit it, including the sandbox wasn't realistic.
> There were a lot of failures.
> 
> Dennis Byrne
> 
> On 2/6/07, Paul Spencer <paulsp@apache.org> wrote:
>>
>> I believe this is what Martin is referring to the Tomahawk test
>> MyFacesTagLibTestCase[1].
>>
>> BTW: It looks like the verification of the sandbox taglibs was commented
>>   out.
>>
>>
>> Paul Spencer
>>
>>
>> [1]http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/test/java/org/apache/myfaces/test/MyFacesTagLibTestCase.java?view=markup

>>
>>
>> Martin Marinschek wrote:
>> > There was someone who wrote an automatic test to check for this - I
>> > don't remember who and when that was, though. Can you have a look into
>> > the test directories and check? Maybe you can extend one of the
>> > test-classes instead of writing a new utility?
>> >
>> > regards,
>> >
>> > Martin
>> >
>> > On 2/6/07, Werner Punz <werpu@gmx.at> wrote:
>> >> Hi
>> >> Since I am currently working on fixing a lot of missing references in
>> >> the sandbox Taglib classes.
>> >> (Some people including me used a lot of includes from entities
>> resulting
>> >> in several missing attribute implementations)
>> >>
>> >> I am going to write, since this seems to be the most obvious way,
>> >> a program which checks the generated component tlds via introspection
>> >> against the taglib classes for those references.
>> >>
>> >> If anyone is willing, to integrate it into maven once I am done
>> >> please drop a note here.
>> >>
>> >> Otherwise is there maybe already a check in maven which does this 
>> test?
>> >> Tomcat is unable to check it as it seems, although I turned on
>> >> tldValidation it did not report errors which were there.
>> >> Also most other app server skip it, but weblogic does not
>> >> and it is correct that it does not skip it.
>> >>
>> >>
>> >>
>> >
>> >
>>
>>
> 
> 


Mime
View raw message