Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (hermes.apache.org: domain of brunoaranda@gmail.com
 designates 64.233.166.176 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=JWfCiZDOBOH4jYbKGXyAbA2l1QB84B3KAFd/fwaFih0XrWEZ4F9Kx9eWOaMpt7uuoxDQh48++WMjmt65cODHFIZDNlgcWylet+ZIH/TOpgpK+3v5GsheFOyqP125PdRLtL+T7vMRj0S2Fr9enP/OhTqJjM3o82BTzdI1sOBHttM=
Message-ID: <1a681ff20610191446g4fabd525n5f77062aa746f48f@mail.gmail.com>
Date: Thu, 19 Oct 2006 22:46:07 +0100
From: "Bruno Aranda" <brunoaranda@gmail.com>
To: "MyFaces Development" <dev@myfaces.apache.org>
Subject: Re: [Faces 1.2] RespStMgr.isPostback()
In-Reply-To: <71235db40610191439j71bf4371h37f84ef5cea50d26@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <71235db40610191253i4879a0e1gdddcc9e5fa4394e9@mail.gmail.com>
	 <71235db40610191254h2be08acej1849e9c23d790500@mail.gmail.com>
	 <4537E223.8050404@gmail.com>
	 <71235db40610191349m353f82d8pe971cfaded1d562f@mail.gmail.com>
	 <1a681ff20610191431k495de42bw3136a19de3cd8550@mail.gmail.com>
	 <71235db40610191439j71bf4371h37f84ef5cea50d26@mail.gmail.com>

Mmm, I see, but these two jsf_state params are not present in the 1.1
myfaces impl trunk, due to some changes Martin did to the
HtmlResponseStateManager class a few days ago...

Bruno

On 10/19/06, Matthias Wessendorf <matzew@apache.org> wrote:
> jsf_state is myfaces. the param was simply forgotten by eg.
> (or at least to specifiy the name of that state_save_param)
>
> javax.faces.ViewState was added to JSF 1.2.
>
> the default needs to check against the param_map_size > 0
> (see javadoc)
>
> you cannot check only agains the javax.faces.ViewState for backward things.
> So my suggestion was doing the check in our htmlRespMgr against all these three
> (the two jsf_state guys from myfaces AND javax....)
>
> -M
>
> On 10/19/06, Bruno Aranda <brunoaranda@gmail.com> wrote:
> > I see that the jsf_state || jsf_state_64 guys have disappeared from
> > the current 1.1 myfaces implementation and replaced by the
> > "javax.faces.ViewState", used by jsf 1.2, so I guess we can just
> > implement as pointer in the jsf 1.2 javadocs (the default impl just
> > checks for the "javax.faces.ViewState" param,
> >
> > Bruno
> >
> > On 10/19/06, Matthias Wessendorf <matzew@apache.org> wrote:
> > > no, I mean,
> > >
> > > why not just abstract isPost() method and letting the impls deal with that?
> > >
> > > best would be to check against view_param. ok, that disables jsf 1.1 from work
> > > so looking for param_map size > 0 is ... ok.
> > >
> > > so each impl can check against view_param (that's jsf 1.2) and! what
> > > they did for jsf 1.1
> > > the jsf_state || jsf_state_64 in case of myfaces and com,sun.xxxx in case of RI
> > >
> > > I don't see why checking (inside the IMPL of myfaces) against
> > > jsf_state || jsf_state_64 || jsf_view_param params will break jsf 1.2
> > >
> > > Since we don't touch the API RespStMgr. guy.
> > >
> > > -M
> > >
> > >
> > > On 10/19/06, Scott O'Bryan <darkarena@gmail.com> wrote:
> > > > I don't know why it's like this either, but unfortunately the snipit
> > > > defines a very clear behavior.  Breaking this contract will break thew
> > > > 1.2 spec.
> > > >
> > > > Scott
> > > >
> > > > Matthias Wessendorf wrote:
> > > > > to fast...  :)
> > > > >
> > > > > my question was, why not as abstract method and let the details to the
> > > > > impl...
> > > > >
> > > > > and we need to *overhaul* this in htmlResp....
> > > > >
> > > > > -M
> > > > >
> > > > > On 10/19/06, Matthias Wessendorf <matzew@apache.org> wrote:
> > > > >> does anyone know, why the spec says for RespStateMgr.isPostback()
> > > > >>
> > > > >>
> > > > >> <snip>
> > > > >> For backwards compatability with implementations of
> > > > >> ResponseStateManager prior to JSF 1.2, a default implementation is
> > > > >> provided that consults the ExternalContext's requestParameterMap and
> > > > >> return true if its size is greater than 0.
> > > > >> </snip>
> > > > >>
> > > > >> http://foo:port/myapp/random.faces?hack=me
> > > > >>
> > > > >>
> > > > >> I think we need (for myfaces) to override the method in the
> > > > >> htmlRespStMgr..
> > > > >> to check against jsf_state || jsf_state_64 || jsf_view_param
> > > > >>
> > > > >> -M
> > > > >>
> > > > >> --
> > > > >> Matthias Wessendorf
> > > > >> http://tinyurl.com/fmywh
> > > > >>
> > > > >> further stuff:
> > > > >> blog: http://jroller.com/page/mwessendorf
> > > > >> mail: mwessendorf-at-gmail-dot-com
> > > > >>
> > > > >
> > > > >
> > > >
> > > >
> > >
> > >
> > > --
> > > Matthias Wessendorf
> > > http://tinyurl.com/fmywh
> > >
> > > further stuff:
> > > blog: http://jroller.com/page/mwessendorf
> > > mail: mwessendorf-at-gmail-dot-com
> > >
> >
>
>
> --
> Matthias Wessendorf
> http://tinyurl.com/fmywh
>
> further stuff:
> blog: http://jroller.com/page/mwessendorf
> mail: mwessendorf-at-gmail-dot-com
>