Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 28394 invoked from network); 7 Sep 2006 11:39:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Sep 2006 11:39:06 -0000 Received: (qmail 45164 invoked by uid 500); 7 Sep 2006 11:39:05 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 45103 invoked by uid 500); 7 Sep 2006 11:39:04 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 45092 invoked by uid 99); 7 Sep 2006 11:39:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Sep 2006 04:39:04 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of manfred.geiler@gmail.com designates 66.249.92.171 as permitted sender) Received: from [66.249.92.171] (HELO ug-out-1314.google.com) (66.249.92.171) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 Sep 2006 04:39:02 -0700 Received: by ug-out-1314.google.com with SMTP id u40so197271ugc for ; Thu, 07 Sep 2006 04:38:41 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=XqQ6rHJHK+t7L9BWkuciR/JD9fCvvcWjnbpJztukHQPWJy5Pie9gx4KmnJTe1oybEF8BEMQeSREm7zg/R8KMXRhDyShEdZb0orvmgTqnBw6QLbOhfyrnCaDm6ZzXNh8IG9aUE5TfEEBRKSBtm54PSTtyD9tBfGwGj/F500y5aTI= Received: by 10.67.101.8 with SMTP id d8mr326741ugm; Thu, 07 Sep 2006 04:38:41 -0700 (PDT) Received: by 10.66.252.1 with HTTP; Thu, 7 Sep 2006 04:38:41 -0700 (PDT) Message-ID: <564d4f680609070438lc28c370s30d270a91ae6df22@mail.gmail.com> Date: Thu, 7 Sep 2006 13:38:41 +0200 From: "Manfred Geiler" To: "MyFaces Development" Subject: Re: GENERATED CODE BEGIN (do not modify!) In-Reply-To: <5a99335f0609070428v5a87f3f3sdadc1726cc52feb1@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <44fdd1d2.4f8174fb.7447.fffffa89@mx.gmail.com> <564d4f680609070410i7361fe10m8b330347ac99797d@mail.gmail.com> <5a99335f0609070428v5a87f3f3sdadc1726cc52feb1@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N No, the config folder is the correct place, because the xml files are not needed during runtime. They are needed during compile time only (during the "process-sources" phase to be exact). They are now in the src folder and therefore not included in the jar - by luck, because maven ignores non-java files in the src tree. ;-) Putting them into the resource folder would make things even worse in that sense! Manfred On 9/7/06, Martin Marinschek wrote: > You mean a resources folder, right? > > regards, > > Martin > > On 9/7/06, Manfred Geiler wrote: > > Dennis, Lance, > > I am indeed of the opinion that is is NOT OK to modify this generated > > code parts. > > Code generation will get importance again when we do the 1.2 port. > > And: Code generation is still important and convenient for coding new > > tomahawk components. Well, nobody seems to use it by now. Reason might > > be (no, I'm sure it IS) the lack of docs. Yes, Lance, you are right, > > there are no docs. Mea culpa. > > And in defense I can not even say it's self-explaining. Because it is not! ;-) > > > > Ok, I give you a very short intro: > > > > Codegenerator can be used by doing a "mvn clean install > > -Pregenerate-component-code" > > You can try it in core/api for instance. > > > > Base for the generation of these code parts is an according xml file > > that looks like this: > > http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/html/HtmlCommandButton.xml?view=markup > > and sits in the same src dir as the component's java file. > > (which is nonsense and should be in a config folder according to the > > maven standard dir layout, of course) > > > > There are some quirks: No dtd or xsd, and so on > > But: it works! And it did a great job in the early days of MyFaces. > > > > HTH and thanks for your interest in this nostalgic thingy :-) > > > > Manfred > > > > > > > > On 9/5/06, L Frohman wrote: > > > Thanks, > > > There is a codegenerator under "build-tools" under "maven". > > > No documentation? (stupid question?) > > > > > > -----Original Message----- > > > From: Dennis Byrne [mailto:dennis@dbyrne.net] > > > Sent: Tuesday, September 05, 2006 12:11 PM > > > To: MyFaces Development > > > Subject: Re: GENERATED CODE BEGIN (do not modify!) > > > > > > Large parts of the original code base were generated. The generator has > > > recently been committed. Check svn ... I forget the name, but it is a > > > seperate sub project. > > > > > > Is anyone else of the opinion that it is now "OK" to modify this code? One > > > doesn't have to look to far to find plenty of undocumented cases where many > > > of us have done this, and for good reasons. > > > > > > Dennis Byrne > > > > > > >-----Original Message----- > > > >From: L Frohman [mailto:lfrohman@gmail.com] > > > >Sent: Tuesday, September 5, 2006 03:00 PM > > > >To: ''MyFaces Development'' > > > >Subject: re: GENERATED CODE BEGIN (do not modify!) > > > > > > > >In several of the myfaces components, there is code marked > > > > > > > >"GENERATED CODE BEGIN (do not modify!)" > > > > > > > >(in particular org.apache.myfaces.component.html.ext.HtmlPanelGroup) > > > >How is this generated? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces >