myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bernd Bohmann (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (TOBAGO-119) Allow custom markup - styles in <tc:out>
Date Sun, 24 Sep 2006 22:26:24 GMT
    [ http://issues.apache.org/jira/browse/TOBAGO-119?page=comments#action_12437260 ] 
            
Bernd Bohmann commented on TOBAGO-119:
--------------------------------------

I would like to add the supported markup configuration as annotation. 
But this doesn't work for JDK 1.4 :-(

Added a supported markup configuration to tobago-theme-config.xml. 

> Allow custom markup - styles in <tc:out>
> ----------------------------------------
>
>                 Key: TOBAGO-119
>                 URL: http://issues.apache.org/jira/browse/TOBAGO-119
>             Project: MyFaces Tobago
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.7, 1.0.8
>         Environment: tobago 1.0.8 nightly jdk 1.4 retro
>            Reporter: Rainer Rohloff
>         Assigned To: Udo Schnurpfeil
>             Fix For: 1.0.9
>
>
> In order to guarantee CI, we need additional layout styles within the tag <tc:out>
> I think an good solution is not to limit the range of values. 
> i.e. 
>    <tc:out value="Hello world" markup="infotext1" />
> with theme-definition
>    .tobago-out-markup-infotext1 {
>       ...
>       border-bottom: 1px solid #b2b2b2;
>       ...
>    }
> possible patch ?
> public final class HtmlRendererUtil {
> if (StringUtils.isNotEmpty(markup)) {
>       if (markup.equals("strong") || markup.equals("deleted")) {
>         tobagoClass.append(prefix).append("-markup-").append(markup).append(" ");
>       } else {
>         LOG.warn("Unknown markup='" + markup + "'");
>       }
> change to:
> if (StringUtils.isNotEmpty(markup)) {
>         tobagoClass.append(prefix).append("-markup-").append(markup).append(" ");
>       if (!markup.equals("strong") && !markup.equals("deleted")) {
>         LOG.info("Not a standard markup='" + markup + "'");
> 	}
> 	  
> OutTagDeclaration:
> @UIComponentTagAttribute(defaultValue = "none", allowedValues = { "none", "strong", "deleted"
})
> change to ???:
> @UIComponentTagAttribute(defaultValue = "none")

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message