myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Marinschek (JIRA)" <...@myfaces.apache.org>
Subject [jira] Updated: (MYFACES-968) LifecycleImpl's restoreView throws NPE when viewId is null in a portlet context
Date Mon, 25 Sep 2006 04:12:51 GMT
     [ http://issues.apache.org/jira/browse/MYFACES-968?page=all ]

Martin Marinschek updated MYFACES-968:
--------------------------------------

           Status: Resolved  (was: Patch Available)
    Fix Version/s: 1.2.0-SNAPSHOT
       Resolution: Fixed
         Assignee: Martin Marinschek

Thanks to Nikolay Petrov for supplying this patch.

regards,

Martin

> LifecycleImpl's restoreView throws NPE when viewId is null in a portlet context
> -------------------------------------------------------------------------------
>
>                 Key: MYFACES-968
>                 URL: http://issues.apache.org/jira/browse/MYFACES-968
>             Project: MyFaces Core
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 1.1.1, 1.1.0, 1.0.9m9
>            Reporter: Dave Brondsema
>         Assigned To: Martin Marinschek
>            Priority: Minor
>             Fix For: 1.2.0-SNAPSHOT
>
>         Attachments: 968.patch
>
>
> LifecycleImpl's restoreView throws exception when viewId is null and in a portlet context
> In restoreView:
> if(viewId == null)
>         {
>             ExternalContext externalContext = facesContext.getExternalContext();
>             if(!externalContext.getRequestServletPath().endsWith("/"))
> In a portlet context getRequestServletPath() returns null *by definition*.  Not only
should we avoid the NPE, but we should do something appropriate for portlets (return to the
'default-view')

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message