Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <21567569.1155693014857.JavaMail.jira@brutus>
Date: Tue, 15 Aug 2006 18:50:14 -0700 (PDT)
From: "Mike Kienenberger (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TOMAHAWK-596) Duplicate id exception for
 HtmlDataScrollerRenderer
In-Reply-To: <4724386.1155424334227.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/TOMAHAWK-596?page=comments#action_12428284 ] 
            
Mike Kienenberger commented on TOMAHAWK-596:
--------------------------------------------

I don't see where it's rendering its children in encodeEnd.   I'm not an expert on renderers, though.

Also, if you could provide a full path in your patches in the future, it'd make applying them easier.
It's not always obvious where xyz.java is located.

It would also be useful if your patch compiled.   Since it doesn't, I'm a bit concerned about applying it :-)
It's missing typecasts from UIComponent to UICommandLink, and this makes me think I'm applying untested code.

-Mike


> Duplicate id exception for HtmlDataScrollerRenderer
> ---------------------------------------------------
>
>                 Key: TOMAHAWK-596
>                 URL: http://issues.apache.org/jira/browse/TOMAHAWK-596
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Data Scroller
>    Affects Versions: 1.1.3
>         Environment: Linux, Windows
>            Reporter: Ryan Wynn
>         Attachments: HtmlDataScrollerRenderer.patch
>
>
> In a portlet environment a non-faces request produces an exception when the faces tree is rendered if the faces tree contains a DataScroller component.  The HtmlDataScroller renderer actually renders its children twice in this case, once in the encodeChildren method and once in the encodeEnd method.  Since rendering of the children is taken care of in encodeEnd I made the encodeChildren method a no-op.  Also, although the  CommandLinks which are rendered as children are marked as transient, they see to stick around.  I put a check in the getLink methods to make sure that the links are not added twice.  This seems to fix the duplicate id exception, but it might be necessary to further investigate why they are sticking around in the first place.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira