myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Kienenberger (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-1386) PropertyResolverImpl.setProperty lacks usefull error mesage if write method not found
Date Wed, 16 Aug 2006 17:01:15 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-1386?page=comments#action_12428438 ] 
            
Mike Kienenberger commented on MYFACES-1386:
--------------------------------------------

Ronald,

That sounds reasonable.

Can you submit this in the form of a patch?


> PropertyResolverImpl.setProperty lacks usefull error mesage if write method not found
> -------------------------------------------------------------------------------------
>
>                 Key: MYFACES-1386
>                 URL: http://issues.apache.org/jira/browse/MYFACES-1386
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 1.1.5-SNAPSHOT
>            Reporter: Ronald Brill
>            Priority: Minor
>
> my managed bean was lacking a setter for a property. Due to a non-descriptive error message
I was unable to identify the source of the problem. After debugging, this code block was identified
that lacks a descriptive error message.
> Error message was:
> Bean: com.somedomain.Controller, property: alertDiffResult Bean: com.somedomain.Controller,
property: alertDiffResult
> Error message should be:
> Bean: com.somedomain.Controller, property: alertDiffResult Bean: com.somedomain.Controller,
property: alertDiffResult (no write method for property)
> suggested patch: 
>   public static void setProperty(Object base, String name, Object newValue)
>     {
>         PropertyDescriptor propertyDescriptor =
>             getPropertyDescriptor(base, name);
>         Method m = propertyDescriptor.getWriteMethod();
>         if (m == null)
>         {
>             throw new PropertyNotFoundException(
>                 getMessage(base, name)+ " (no write method for property!)");
>         }
> ...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message