Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Message-ID: <9980857.1148290891065.JavaMail.jira@brutus>
Date: Mon, 22 May 2006 09:41:31 +0000 (GMT+00:00)
From: "Jon Harley (JIRA)" <dev@myfaces.apache.org>
To: dev@myfaces.apache.org
Subject: [jira] Commented: (TOMAHAWK-432) maxlength attribute of
 inputFileUpload now sets both the input field size and the file size
In-Reply-To: <19212890.1147448648459.JavaMail.root@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

    [ http://issues.apache.org/jira/browse/TOMAHAWK-432?page=3Dcomments#act=
ion_12412750 ]=20

Jon Harley commented on TOMAHAWK-432:
-------------------------------------

maxlength is a valid attribute of input for all versions of HTML including =
XHTML. There is NO version of HTML in which it means limit max file size, s=
o adding this behaviour to inputFileUpload is inherently confusing.

I agree that configuration of file size should be defined globally, which w=
as the only way in MyFaces 1.1.1. Unfortunately the new behaviour of maxlen=
gth OVERRIDES the global configuration. This caused all my file inputs to b=
reak when I upgraded, and the same will happen for everyone else who has us=
ed maxlength on file inputs before upgrading to Tomahawk 1.1.2.

But if you don't care about introducing confusing attribute names and break=
ing people's applications, by all means leave this bug unfixed.

> maxlength attribute of inputFileUpload now sets both the input field size=
 and the file size
> -------------------------------------------------------------------------=
------------------
>
>          Key: TOMAHAWK-432
>          URL: http://issues.apache.org/jira/browse/TOMAHAWK-432
>      Project: MyFaces Tomahawk
>         Type: Bug

>   Components: File Upload
>     Versions: 1.1.2
>     Reporter: Jon Harley
>     Assignee: Matthias We=C3=9Fendorf

>
> The maxlength attribute of the inputFileUpload tag is supposed to set the=
 maximum number of characters you can enter in the text input part of the f=
ile input. This is documented in the tag library javadoc and was the behavi=
our in MyFaces 1.1.1 (it is also the intuitive behaviour, since maxlength i=
s used for this in the HTML file input tag).
> As of Tomahawk 1.1.2, the component refuses to upload files with a size I=
N BYTES greater than the size of the maxlength attribute, giving the messag=
e from org.apache.myfaces.FileUpload.SIZE_LIMIT
> It is not appropriate to overload the maxlength attribute to set both the=
 width of the input field and the size of the file - please regress to the =
behaviour in 1.1.1!

--=20
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira