Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 19075 invoked from network); 27 Apr 2006 15:43:27 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 27 Apr 2006 15:43:27 -0000 Received: (qmail 68620 invoked by uid 500); 27 Apr 2006 15:43:07 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 68312 invoked by uid 500); 27 Apr 2006 15:43:05 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 68019 invoked by uid 99); 27 Apr 2006 15:43:04 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2006 08:43:04 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Apr 2006 08:43:03 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 388A77142B6 for ; Thu, 27 Apr 2006 15:42:40 +0000 (GMT) Message-ID: <6318177.1146152560229.JavaMail.jira@brutus> Date: Thu, 27 Apr 2006 15:42:40 +0000 (GMT+00:00) From: "Richard van Nieuwenhoven (JIRA)" To: dev@myfaces.apache.org Subject: [jira] Updated: (TOBAGO-60) Application-Converter ist not used for tx:date component In-Reply-To: <30065155.1146152559748.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/TOBAGO-60?page=all ] Richard van Nieuwenhoven updated TOBAGO-60: ------------------------------------------- Status: Patch Available (was: Open) > Application-Converter ist not used for tx:date component > -------------------------------------------------------- > > Key: TOBAGO-60 > URL: http://issues.apache.org/jira/browse/TOBAGO-60 > Project: MyFaces Tobago > Type: Bug > Versions: 1.0.7 > Reporter: Richard van Nieuwenhoven > Priority: Minor > > only the local converter is used for tx:date valuebinding conversions > the java jsf doc says we should also use the application-global-version: > http://java.sun.com/javaee/javaserverfaces/1.1_01/docs/api/javax/faces/component/UIOutput.html > To fix this we made the following changes: > 1. In the class org.apache.myfaces.tobago.renderkit.html.scarborough.standard.tag.InRendererBase.java > we included this method: > protected Converter getConverter(FacesContext facesContext, UIOutput component) { > Converter converter = component.getConverter(); > if (converter != null) > return converter; > ValueBinding vb = component.getValueBinding("value"); > if (vb == null) > return null; > return facesContext.getApplication().createConverter(vb.getType(facesContext)); > } > in the method "protected void renderMain(FacesContext facesContext, UIInput input,TobagoResponseWriter writer) throws IOException" > we replaced the "component.getConverter()" with "getConverter(facesContext, input)" > 2. in the class org.apache.myfaces.tobago.renderkit.html.scarborough.standard.tag.DateRenderer we also changed the "((UIOutput) component).getConverter()" with "getConverter(facesContext, (UIOutput) component)" > please include this in the next release. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira