myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dennis Byrne" <den...@dbyrne.net>
Subject Re: Detection of ExtensionsFilter
Date Sat, 01 Apr 2006 18:53:07 GMT
OK, so I guess it *still* puts the flag there ;)

Dennis Byrne

>-----Original Message-----
>From: Sylvain Vieujot [mailto:svieujot@apache.org]
>Sent: Saturday, April 1, 2006 01:50 PM
>To: 'MyFaces Development'
>Subject: Re: Detection of ExtensionsFilter
>
>You could do :
>if( request.getAttribute(org.apache.myfaces.webapp.filter.ExtensionsFilter.DOFILTER_CALLED)!=null
)
>
>But the DOFILTER_CALLED variable is private.
>Maybe hack it with a copy of the String.
>If you find it useful, maybe the clean way would be to add an
>hasBeenCalled public static method to the ExtensionsFilter.
>
>Sylvain.
>
>On Sat, 2006-04-01 at 20:37 +0200, Mario Ivankovits wrote:
>
>> Hi!
>> > Perhaps this check could be moved to application scope
>> Yes, I also tought about it.
>> 
>> > You many also want to perform this check with a quick SAX ( less memeory than
DOM ) handler for the deployment descriptor in order to determine which filters an app has.
>> I think its too hard and too error prone to detect if the extensions
>> filter is correctly setup. And e.g. in our application we call the
>> extensions filter from our own filter, so the extension filter didnt
>> show up in web.xml (for sure the resource provider is configured, but
>> not the one which is responsible to parse the response)
>> But, yes ... I'll check both use cases of the extensions filter, so it
>> might be required to parse web.xml anyway.
>> 
>> > Just a few ideas.
>> >   
>> Thanks!
>> 
>> 
>> Ciao,
>> Mario
>> 
>



Mime
View raw message