Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 78724 invoked from network); 30 Mar 2006 16:00:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 30 Mar 2006 16:00:41 -0000 Received: (qmail 73361 invoked by uid 500); 30 Mar 2006 16:00:38 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 73118 invoked by uid 500); 30 Mar 2006 16:00:37 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 73101 invoked by uid 99); 30 Mar 2006 16:00:37 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Mar 2006 08:00:37 -0800 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=RCVD_IN_BL_SPAMCOP_NET,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of mkienenb@gmail.com designates 64.233.182.188 as permitted sender) Received: from [64.233.182.188] (HELO nproxy.gmail.com) (64.233.182.188) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Mar 2006 08:00:36 -0800 Received: by nproxy.gmail.com with SMTP id c31so391476nfb for ; Thu, 30 Mar 2006 08:00:15 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=WXRijmqjiLQyR6S5ByqOKO+2v4pdP3ycEtYTKXg/Aa/jiZMvT6bTb9Po64KEbReRPgTjMxtIGRgPUEtnuzk+RSyHzPGAR+oXWakkmRH0PHlbrdbYvC7VzmiMUntfs0oviE5jvkWJMd+/o8tg6YvnGavlk618y14l7N8B6y9ESuQ= Received: by 10.48.226.11 with SMTP id y11mr1012853nfg; Thu, 30 Mar 2006 08:00:15 -0800 (PST) Received: by 10.48.48.19 with HTTP; Thu, 30 Mar 2006 08:00:15 -0800 (PST) Message-ID: <8f985b960603300800g6534a88ay1d9560d583bdd13a@mail.gmail.com> Date: Thu, 30 Mar 2006 11:00:15 -0500 From: "Mike Kienenberger" To: "MyFaces Development" Subject: Re: please review commit r390142 In-Reply-To: <442BEC97.6000604@ops.co.at> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <442BEC97.6000604@ops.co.at> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 3/30/06, Mario Ivankovits wrote: > Could one please review my commit r390142 (see commits@). > > It is a try to throw an exception if one add more then one child to a > facet. I've done this after I 2 hours of searching a problem in our > application just to figure out it was due to multiple facet children. > > The if (id....) stuff is required during restoreView. > > It turns out to work here, but its a deep change so I wanted to inform > you about it. So we can early remove it if it was a bad idea ;-) Hey Mario, it looks like a good idea to me! Don't see anything wrong with the implementation either.