myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mike Kienenberger" <>
Subject Re: please review commit r390142
Date Thu, 30 Mar 2006 16:00:15 GMT
On 3/30/06, Mario Ivankovits <> wrote:
> Could one please review my commit r390142 (see commits@).
> It is a try to throw an exception if one add more then one child to a
> facet. I've done this after I 2 hours of searching a problem in our
> application just to figure out it was due to multiple facet children.
> The if (id....) stuff is required during restoreView.
> It turns out to work here, but its a deep change so I wanted to inform
> you about it. So we can early remove it if it was a bad idea ;-)

Hey Mario, it looks like a good idea to me!
Don't see anything wrong with the implementation either.

View raw message