Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 76425 invoked from network); 25 Jan 2006 09:06:15 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 25 Jan 2006 09:06:15 -0000 Received: (qmail 2909 invoked by uid 500); 25 Jan 2006 09:06:14 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 2795 invoked by uid 500); 25 Jan 2006 09:06:13 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 2780 invoked by uid 99); 25 Jan 2006 09:06:13 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2006 01:06:13 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of martin.marinschek@gmail.com designates 64.233.184.200 as permitted sender) Received: from [64.233.184.200] (HELO wproxy.gmail.com) (64.233.184.200) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Jan 2006 01:06:12 -0800 Received: by wproxy.gmail.com with SMTP id i2so142014wra for ; Wed, 25 Jan 2006 01:05:51 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=bJyeVbAaw3euTETfjMKzns0C5OQQPfRgr2hklQYdcnfC9hR+mKHenH8FBBH9j7K8d0ZGMNzY5h/idkEMPv4Csc4DpaGobhtetEty4lz5e/02lHVtFjDmt6rigqTan1XTqqoS2XbktgnlKB29qnvTnyU2JI6sO2ikpECl17+IAbM= Received: by 10.65.74.17 with SMTP id b17mr93900qbl; Wed, 25 Jan 2006 01:05:51 -0800 (PST) Received: by 10.65.188.10 with HTTP; Wed, 25 Jan 2006 01:05:51 -0800 (PST) Message-ID: <5a99335f0601250105x2117f588o1b1e19fcd48fe1ae@mail.gmail.com> Date: Wed, 25 Jan 2006 10:05:51 +0100 From: Martin Marinschek Reply-To: mmarinschek@apache.org To: MyFaces Development , skitching@apache.org Subject: Re: Re: NamingContainer.SEPARATOR_CHAR In-Reply-To: <1138161412.4918.104.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <29308525.131841138138217539.JavaMail.servlet@perfora> <1138161412.4918.104.camel@localhost.localdomain> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Yes, you have a point here. but in fact, autogenerated id's don't start with _, but with _id. and if we do that, I again loose my ability to make a distinction between a row-id and a sub-component-id :( regards, Martin On 1/25/06, Simon Kitching wrote: > Firstly, the format used when a table modifies the client-id to ensure > row uniqueness is not in the spec as far as I know, so any code that > depends on client ids of a specific layout isn't valid. > > Secondly, MyFaces traditionally used _rownum rather than :rownum anyway, > and only changed to using a colon like RI after the last release. So > changing it now is no problem as far as I can see. > > I agree that ":" is logical, as the per-row behaviour is very like each > row is a NamingContainer. I also suggest that "_" on the front of the > number is the logical behaviour (though not specified). > > > On Tue, 2006-01-24 at 16:30 -0500, jacob@hookom.net wrote: > > You don't want to massage API client ids from what exists now, that's a= pretty dramatic > > change for people that have expected those ids within the UI. > > > > > > > >On Tue, 2006-01-24 at 16:12 +0100, Martin Marinschek wrote: > > >> Ok > > >> > > >> I've discussed with Manfred some more, and we agreed upon the fact > > >> that mixing the two approaches together would be the best solution. > > >> > > >> So you have the normal findComponent() call on a naming-container, a= nd > > >> if this naming container is doing something special to it's componen= ts > > >> and it finds the referential information for setting this context up > > >> in the client-id, we deliver back a properly initialized perspective= . > > >> > > >> Now if we want to do some serious work on the component itself, we'l= l > > >> have a "visit" or "execute" method on the perspective, with which yo= u > > >> can actually do the serious work on the properly initialized > > >> component. > > > > > >+1. > > > > > >The only potential issue is code that calls findComponent then casts t= he > > >result to a specific UIComponent subclass. But any such code that is > > >passing an id with an embedded rowId in it is probably not doing what = is > > >expected at the current time anyway. > > > > > > > > > > > >> By the way - I've also talked to John Fallows about this - he is not > > >> 100% d'accord, but he sees the basic problem as well. What he propos= es > > >> is a customized lifecycle, along with a filter, just like in > > >> ADF-faces. > > > > > >I'd be interested in hearing more about that. Can you post a summary? > > > > > > > > >I'd just like to bring up my earlier proposal again: to move to using > > >"_{rownum}" rather than just {rownum} for the index. As the rownum is = a > > >generated id, and generated ids are required to start with "_" I think > > >this would be the right thing to do. Example: > > > form1:table1:_3:component1 > > > > > >Regards, > > > > > >Simon > > > > > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces