myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Marinschek <martin.marinsc...@gmail.com>
Subject Re: Maven Build (Ongoing Work Thread)
Date Tue, 03 Jan 2006 11:54:30 GMT
Thanks Bernd,

just committed the guy.

regards,

Martin

On 1/3/06, Bernd Bohmann <bernd.bohmann@atanion.com> wrote:
> Hello,
>
> please apply this patch to the pom in the build directory to simplfy the
> build process.
> Changes:
> Added default goal
> Removed tabs
> Added www.atanion.com/maven2 as snapshot plugin repository
> Changed list to List in mailingLists
> Changed finalname to myfaces-${version}
> Skipped the tests until they are stable
>
> With this patch the xslt-plugin is fetched from the atanion maven
> repositry, you don't need to install the xslt-plugin to your local
> repository manualy. I have deployed the xslt-plugin into the atanion
> maven repository (with the patch for
> http://jira.codehaus.org/browse/MOJO-203).
>
>
> Some other comments on the maven build to improve the build:
>
> Please use as much as possible the ${version} instead of hardcoding the
> version and remove the <version> tag if a parent pom exists(but not in
> the parent description see tobago poms).
> Please move the assembly plugin configuration in the master pom to api
> or impl otherwise every subproject try to call the assembly plugin.
> Can we removed the svn externals. With the maven build they are useless
> for api, impl, commons, tomahawk, sandbox..
> It would be nice if the master pom is in the root directory of myfaces.
> Some plugin (idea) are not working with the current structure.
>
> Any comments
>
> Best Regards
>
> Bernd
>
>
>
> Bernd Bohmann schrieb:
> > Hello Sean,
> >
> > I think the current version of the surefire-plugin doesn't support the
> > forking mode. This is fixed in the latest not yet released version.
> > I see the StateUtils are using a static block for loading the
> > properties. I don't know how this can work if your are in one JVM?
> >
> > I think you have two options:
> > Disable the test until the new version of the surefire plugin is
> > released or change the test to a mock version.
> >
> > Any comments?
> >
> > The StateUtilsAES_CBCTestCase doesn't work in my environment.
> > A missing dependency or wrong configuration?
> > I get following error:
> >
> > java.security.InvalidKeyException: Illegal key size
> >
> >
> > Bernd
> >
> > Sean Schofield schrieb:
> >
> >> Dennis,
> >>
> >> I'm still having issues with the client state encryption tests.  Can
> >> you find a way to make them run in Maven?
> >>
> >> Sean
> >>
> >> On 1/2/06, Bernd Bohmann <bernd.bohmann@atanion.com> wrote:
> >>
> >>> Done
> >>>
> >>> http://jira.codehaus.org/browse/MOJO-203
> >>>
> >>> Sean Schofield schrieb:
> >>>
> >>>> You beat me to the patch :-)  Can you submit this to codehaus in their
> >>>> JIRA so eventually it makes it into the real source code?
> >>>>
> >>>> Regards,
> >>>>
> >>>> Sean
> >>>>
> >>>> On 1/2/06, Bernd Bohmann <bernd.bohmann@atanion.com> wrote:
> >>>>
> >>>>
> >>>>> Hello Martin,
> >>>>>
> >>>>> the xslt-maven-plugin doesn't create destDir if not exists.
> >>>>>
> >>>>> Please apply the patch:
> >>>>>
> >>>>> Index: src/main/java/org/codehaus/mojo/xslt/XsltMojo.java
> >>>>> ===================================================================
> >>>>> --- src/main/java/org/codehaus/mojo/xslt/XsltMojo.java  (Revision
> >>>>> 1181)
> >>>>> +++ src/main/java/org/codehaus/mojo/xslt/XsltMojo.java  (Arbeitskopie)
> >>>>> @@ -116,6 +116,10 @@
> >>>>>                 {
> >>>>>                     destFileName = destFileName.replaceAll(
> >>>>> fileNameRegex, fileNameReplacement );
> >>>>>                 }
> >>>>> +               if( !destDir.exists() )
> >>>>> +               {
> >>>>> +                   destDir.mkdirs();
> >>>>> +               }
> >>>>>                 File destFile = new File( destDir, destFileName
);
> >>>>>
> >>>>>                 if ( destFile.exists() && srcFile.lastModified()
<
> >>>>> destFile.lastModified() )
> >>>>>
> >>>>>
> >>>>> Bernd
> >>>>>
> >>>>> Martin Marinschek schrieb:
> >>>>>
> >>>>>
> >>>>>> The build doesn't run on my machine anymore - ok, it runs, but
the
> >>>>>> tld
> >>>>>> files are not created anymore.
> >>>>>>
> >>>>>> The tld's cannot be created, as the target/classes/META-INF
directory
> >>>>>> doesn't exist.
> >>>>>>
> >>>>>> Solution anyone?
> >>>>>>
> >>>>>> regards,
> >>>>>>
> >>>>>> Martin
> >>>>>>
> >>>>>> On 1/2/06, John Fallows <john.r.fallows@gmail.com> wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> Devs,
> >>>>>>>
> >>>>>>> On 1/1/06, chemeia@gmail.com <chemeia@gmail.com> wrote:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Changes to the TLD files don't seem to be being picked
up at
> >>>>>>>> build time;
> >>>>>>>
> >>>>>>>
> >>>>>>> this was a problem in the Ant build as well but 'ant clean'
fixed
> >>>>>>> it there,
> >>>>>>> but 'mvn clean' doesn't here.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> My situation:  I editied
> >>>>>>>
> >>>>>>>
> >>>>>>> tomahawk/src/main/tld/tomahawk-entities/tomahawk_validate_equal_attributes.xml
> >>>>>>>
> >>>>>>> and ran 'mvn install'.  My changes didn't take, so I did
a 'mvn
> >>>>>>> clean' then
> >>>>>>> a 'mvn install'.  Changes still aren't picked up.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> I suspect it's the cached intermediate file at
> >>>>>>>
> >>>>>>>
> >>>>>>> tomahawk\src\main\resources\META-INF\tomahawk.tld that's
> >>>>>>> causing the problem.  It isn't deleted by a clean.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> [INFO]
> >>>>>>>
> >>>>>>>
> >>>>>>> ----------------------------------------------------------------------------
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> [INFO] Building Tomahawk
> >>>>>>>> [INFO]    task-segment: [install]
> >>>>>>>> [INFO]
> >>>>>>>
> >>>>>>>
> >>>>>>> ----------------------------------------------------------------------------
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> [INFO] [xslt:transform {execution: default}]
> >>>>>>>> [INFO] # of XML files: 1
> >>>>>>>> [INFO] file up-to-date:
> >>>>>>>
> >>>>>>>
> >>>>>>> C:\work\workspace\myfaces-current-postreorg\build\..\tomahawk\src\main\resources\META-INF\tomahawk.tld
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> All generated files should live in the target subdirectory,
> >>>>>>> including
> >>>>>>> generated resources such as .tld files.
> >>>>>>>
> >>>>>>> In ADF Faces we merge together a base .tld from
> >>>>>>> src/main/conf/META-INF/xxx-base.tld with other metadata
to generate
> >>>>>>> target/[plugin-name]/src/main/resources/META-INF/xxx.tld,
> >>>>>>> and the plugin automatically adds
> >>>>>>> target/[plugin-name]src/main/resources to the resource root
> >>>>>>> set (similar to java source path for javac).
> >>>>>>>
> >>>>>>> When the IDE projects are generated - we use JDeveloper
:-) -
> >>>>>>> both the
> >>>>>>> xxx-base.tld and the xxx.tld files are visible in the merged
> >>>>>>> resources tree
> >>>>>>> view.  When either the xxx-base.tld file or other relevant
> >>>>>>> metadata is
> >>>>>>> changed, we re-run mvn generate-resources to regenerate
> >>>>>>> target/[plugin-name]/src/main/resources/META-INF/xxx.tld,
> >>>>>>> without needing to do a clean build.
> >>>>>>>
> >>>>>>> Since src/main/resources and
> >>>>>>> target/[plugin-name]/src/main/resources are both registered
> >>>>>>> as resource roots, but src/main/conf is not, then the
> >>>>>>> xxx-base.tld is not
> >>>>>>> included in the JAR, but xxx.tld is included, as desired.
> >>>>>>>
> >>>>>>> Kind Regards,
> >>>>>>> John Fallows.
> >>>>>>>
> >>>>>>> --
> >>>>>>> Author Pro JSF and Ajax: Building Rich Internet Components
> >>>>>>> http://www.apress.com/book/bookDisplay.html?bID=10044
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> --
> >>>>>>
> >>>>>> http://www.irian.at
> >>>>>>
> >>>>>> Your JSF powerhouse -
> >>>>>> JSF Consulting, Development and
> >>>>>> Courses in English and German
> >>>>>>
> >>>>>> Professional Support for Apache MyFaces
> >>>>>>
> >>>>>
> >>>>> --
> >>>>> Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development
> >>>>> Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com
> >>>>> phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
> >>>>>
> >>>>>
> >>>>>
> >>>>
> >>>>
> >>> --
> >>> Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development
> >>> Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com
> >>> phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
> >>>
> >>
> >>
> >
>
> --
> Dipl.-Ing. Bernd Bohmann - Atanion GmbH - Software Development
> Bismarckstr. 13, 26122 Oldenburg, http://www.atanion.com
> phone: +49 441 4082312, mobile: +49 173 8839471, fax: +49 441 4082333
>
>
>


--

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Mime
View raw message