myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno Aranda (JIRA)" <...@myfaces.apache.org>
Subject [jira] Reopened: (MYFACES-27) JSCookmenu cannot be used for storing data
Date Fri, 13 Jan 2006 08:34:21 GMT
     [ http://issues.apache.org/jira/browse/MYFACES-27?page=all ]
     
Bruno Aranda reopened MYFACES-27:
---------------------------------

     Assign To: Bruno Aranda  (was: Martin Marinschek)

>From Igor Marakov, in the users mailing list:

<<
In the last build that I have ( 12/12 ) JSCookmenu fix to allow component to work within form
and submit forms is incomplete.

There are still two issues in the code preventing it from operating properly. Below is a description
and temporary fixes.

 

   1. Even though code to find enclosing form is in place and does work, Javascript component
org.apache.myfaces.custom.navmenu.jscookmenu.resources.MyFacesHack.js still refers to and
submits dummy form. I guess it was forgotten about...

Code can be fixed by changing the following line in cmItemMouseUp function

var dummyForm = document.forms['linkDummyForm']; with var dummyForm = document.forms[target];

 

   2. There is still hardwired 'immediate' attribute in the org.apache.myfaces.custom.navmenu.jscookmenu.HtmlCommandJSCookMenu.java
class. Although reasoning for this is still not known ( see myfaces-27 discussion ) I would
guess it is a intention of the original design of the component to be pure navigational solution
therefore short-circuiting processing cycle. Even though I would favor solution to make 'immediate'
attribute configurable, for the time being for those who need working component right now
( like me :(  )  the temporary solution is to patch the class overriding isImmediate() and
setImmediate() methods as follows:

 

public void setImmediate(boolean flag) { super.setImmediate(false); }

public boolean isImmediate() { return false; }
 
Although I this is not a proper solution these two patches produce jscookmenu component that
pretends :) to be working.

Maybe issue 27 needs to be reopened to get this fixed for good?

Thanks,

Igor
>>


> JSCookmenu cannot be used for storing data
> ------------------------------------------
>
>          Key: MYFACES-27
>          URL: http://issues.apache.org/jira/browse/MYFACES-27
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.7 beta
>  Environment: JBoss 4.0
>     Reporter: Tobias Neubert
>     Assignee: Bruno Aranda
>     Priority: Critical
>      Fix For: 1.1.2
>  Attachments: jscookFormPatch.txt
>
> JSCookmenu has hardcoded "immediate" attribute on "true". This cause that an action,
which should store data from the view, is executed after the apply_request_values-phase instead
of the application-execute-phase. But at that time the model values are not updated with the
view-values, so a empty objekt is stored.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message