myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Adam Winer <awi...@gmail.com>
Subject Re: NavigationHandlerImpl and viewId
Date Fri, 23 Dec 2005 00:16:39 GMT
On 12/22/05, Martin Marinschek <martin.marinschek@gmail.com> wrote:
> This is the comment in viewHandler.createView():
>
> //      as of JSF spec page 7-16:
> //      "It is the callers responsibility to ensure that setViewId() is called
> //      on the returned view, passing the same viewId value."
> //      so we do not set the viewId here
>
> //      ok, but the RI does so, so let's do it, too.
>
> So we do call the viewRoot.setViewId(); in createView, but then call
> it afterwards as well. Which really doesn't make any sense!
>
> I'll get rid of the offending statement - Adam, can you check back if
> there is something unclear in the spec?

The spec text here is *freaky*!  The Javadoc on createView() seems perfectly
clear that the viewId should be set on the UIViewRoot automatically.

I've filed an issue against the spec.

-- Adam

Mime
View raw message