myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Kitching (JIRA)" <...@myfaces.apache.org>
Subject [jira] Closed: (MYFACES-787) defining attributes in tomahawk.tld makes it difficult to subclass tomahawk components
Date Tue, 20 Dec 2005 21:14:32 GMT
     [ http://issues.apache.org/jira/browse/MYFACES-787?page=all ]
     
Simon Kitching closed MYFACES-787:
----------------------------------

    Resolution: Fixed

Ok, I've now moved all inline attributes out of tomahawk.tld and myfaces_html.tld.

I don't think it's worth doing for myfaces_core.tld, as that is a very stable file, and fairly
small.

I haven't bothered doing it for sandbox; anyone trying to subclass sandbox components is crazy
:-)
When components migrate from sandbox to tomahawk they will hopefully be modified then to avoid
inline attributes.

> defining attributes in tomahawk.tld makes it difficult to subclass tomahawk components
> --------------------------------------------------------------------------------------
>
>          Key: MYFACES-787
>          URL: http://issues.apache.org/jira/browse/MYFACES-787
>      Project: MyFaces
>         Type: Improvement
>     Reporter: Simon Kitching
>  Attachments: html_column_attributes.xml, tomahawk.tld.patch
>
> The tomahawk.tld file uses xml entities to reference some attributes shared between components.
> However the attributes for tomahawk components are defined in-line in the tomahawk.tld
file.
> When subclassing a tomahawk component to extend it, all of the text needs to be copied
into the tld
> where the derived component is defined - ugly, esp. for things like HtmlColumn that have
dozens of
> attributes.
> Attached is a patch to simply move the attributes defined in tomahawk.tld for the HtmlColumn
tag
> into an external entity file, thus allowing derived classes to just reference this entity
file.
> I'm happy to provide patches to move all defined attributes for other tomahawk components
into
> entity files too, though it probably takes more time to apply/commit such patches than
it would for
> a MyFaces committer to make this change directly.
> One possible variant on this patch is to move the other entity refs which are used by
HtmlColumn
> into the html_column_attributes.xml file, so that the HtmlColumn definition in tomahawk.tld
just
> contains one reference. That makes subclassing even easier, and seems sensible. It's
a slightly
> more adventurous change, though, so I've submitted the simpler approach as the patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message