Return-Path: Delivered-To: apmail-myfaces-dev-archive@www.apache.org Received: (qmail 83112 invoked from network); 3 Nov 2005 10:18:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 3 Nov 2005 10:18:07 -0000 Received: (qmail 27883 invoked by uid 500); 3 Nov 2005 10:18:06 -0000 Delivered-To: apmail-myfaces-dev-archive@myfaces.apache.org Received: (qmail 27576 invoked by uid 500); 3 Nov 2005 10:18:05 -0000 Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "MyFaces Development" Delivered-To: mailing list dev@myfaces.apache.org Received: (qmail 27563 invoked by uid 99); 3 Nov 2005 10:18:05 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2005 02:18:05 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of martin.marinschek@gmail.com designates 66.249.82.201 as permitted sender) Received: from [66.249.82.201] (HELO xproxy.gmail.com) (66.249.82.201) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2005 02:18:00 -0800 Received: by xproxy.gmail.com with SMTP id s12so620137wxc for ; Thu, 03 Nov 2005 02:17:44 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=QgySm0I/tHXWDWi7rU77Xi5w4i0uUh4Tvnsx3ZXRO23by8tiLf1Frko9V0rKHKFsDoGg4adgytjTvXKNnCwGkDvypkBwwi3XNOEYGFr3Rk6akrJtQ9UBGQ2iLGGUPypnNM7GUh7CNXOhST8OQpIk25tNAad3SKnFjFQfo0Sa7VU= Received: by 10.70.7.20 with SMTP id 20mr504986wxg; Thu, 03 Nov 2005 02:17:43 -0800 (PST) Received: by 10.70.48.16 with HTTP; Thu, 3 Nov 2005 02:17:43 -0800 (PST) Message-ID: <5a99335f0511030217y15dde2c4x97dfa7308d22170@mail.gmail.com> Date: Thu, 3 Nov 2005 11:17:43 +0100 From: Martin Marinschek Reply-To: mmarinschek@apache.org To: MyFaces Development Subject: Re: svn commit: r330515 - /myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspStateManagerImpl.java In-Reply-To: <20051103090235.53451.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <20051103090235.53451.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N I wonder if we should make this optional - while we have load tests currently which show that the problem is processor time, it might be the case that with a different machine configuration and application configuration the problem might be memory usage, right? regards, Martin On 11/3/05, mbr@apache.org wrote: > Author: mbr > Date: Thu Nov 3 01:02:29 2005 > New Revision: 330515 > > URL: http://svn.apache.org/viewcvs?rev=3D330515&view=3Drev > Log: > state is not longer gzipped if server side state is used to improve perfo= rmance. > > Modified: > myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspSta= teManagerImpl.java > > Modified: myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/= JspStateManagerImpl.java > URL: http://svn.apache.org/viewcvs/myfaces/impl/trunk/src/java/org/apache= /myfaces/application/jsp/JspStateManagerImpl.java?rev=3D330515&r1=3D330514&= r2=3D330515&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspSta= teManagerImpl.java (original) > +++ myfaces/impl/trunk/src/java/org/apache/myfaces/application/jsp/JspSta= teManagerImpl.java Thu Nov 3 01:02:29 2005 > @@ -28,12 +28,9 @@ > import java.util.List; > import java.util.Map; > import java.util.Set; > -import java.util.zip.GZIPInputStream; > -import java.util.zip.GZIPOutputStream; > > import javax.faces.FactoryFinder; > import javax.faces.application.StateManager; > -import javax.faces.application.StateManager.SerializedView; > import javax.faces.component.NamingContainer; > import javax.faces.component.UIComponent; > import javax.faces.component.UIViewRoot; > @@ -449,7 +446,7 @@ > ByteArrayOutputStream baos =3D new ByteArrayOutputStream(102= 4); > try > { > - ObjectOutputStream out =3D new ObjectOutputStream(new GZ= IPOutputStream(baos)); > + ObjectOutputStream out =3D new ObjectOutputStream(baos); > out.writeObject(serializedView.getStructure()); > out.writeObject(serializedView.getState()); > out.close(); > @@ -490,8 +487,8 @@ > { > try > { > - ObjectInputStream in =3D new ObjectInputStream(new GZIPI= nputStream( > - new ByteArrayInputStream((byte[]) state))); > + ObjectInputStream in =3D new ObjectInputStream( > + new ByteArrayInputStream((byte[]) state)); > return new SerializedView(in.readObject(), in.readObject= ()); > } > catch (IOException e) > > > -- http://www.irian.at Your JSF powerhouse - JSF Trainings in English and German