myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ken Weiner (JIRA)" <...@myfaces.apache.org>
Subject [jira] Commented: (MYFACES-210) Undesired dependency on ApplicationImpl in FacesConfigurator
Date Wed, 30 Nov 2005 19:04:32 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-210?page=comments#action_12358943 ] 

Ken Weiner commented on MYFACES-210:
------------------------------------

> You cannot configure properties on a converter instance from faces-config.xml.

Adam,  are you saying that the http://java.sun.com/dtd/web-facesconfig_1_1.dtd is not correct?
 That DTD indicates that converter elements can have both attribute and property child elements,
each of which can have values.  If no attributes and properties should be specified via faces-config.xml,
should the converterConfig be removed from FacesConfigurator and ApplicationImpl?:

Here are the DTD sections for converter, attribute, and property for reference:

<!--
    The "converter" element represents a concrete Converter implementation
    class that should be registered under the specified converter identifier.
    Converter identifiers must be unique within the entire web application.

    Nested "attribute" elements identify generic attributes that may be
    configured on the corresponding UIComponent in order to affect the
    operation of the Converter.  Nested "property" elements identify JavaBeans
    properties of the Converter implementation class that may be configured
    to affect the operation of the Converter.
-->
<!ELEMENT converter       (description*, display-name*, icon*, (converter-id | converter-for-class),
converter-class, attribute*, property*)>

<!--
    The "attribute" element represents a named, typed, value associated with
    the parent UIComponent via the generic attributes mechanism.

    Attribute names must be unique within the scope of the parent (or related)
    component.
-->
<!ELEMENT attribute       (description*, display-name*, icon*, attribute-name, attribute-class,
default-value?, suggested-value?, attribute-extension*)>

<!--
    The "property" element represents a JavaBean property of the Java class
    represented by our parent element.

    Property names must be unique within the scope of the Java class
    that is represented by the parent element, and must correspond to
    property names that will be recognized when performing introspection
    against that class via java.beans.Introspector.
-->
<!ELEMENT property        (description*, display-name*, icon*, property-name, property-class,
default-value?, suggested-value?, property-extension*)>



> Undesired dependency on ApplicationImpl in FacesConfigurator
> ------------------------------------------------------------
>
>          Key: MYFACES-210
>          URL: http://issues.apache.org/jira/browse/MYFACES-210
>      Project: MyFaces
>         Type: Bug
>   Components: Implementation
>     Versions: 1.0.9m9
>  Environment: Custom ApplicationFactory and Application Objects
>     Reporter: Walter Snel
>     Assignee: Martin Marinschek
>     Priority: Minor

>
> Manfred's recent additions related to the configurability of Converters created a dependency
on a particular Application implementation in the FacesConfigurator.
> I noticed this because I'm using a custom ApplicationFactory that returns a custom Facade
(with augmentations) to the ApplicationImpl class.
> In this case the FacesConfigurator doesn't call the addConverterConfiguration. This,
later on, leads to horrible nullpointer exceptions when any of standard converters are used.
Perhaps we could consider using relfection instead of the current 'instanceof' mechanism to
find out if the addConverterConfiguration() method is supported ?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message