myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Bill Dudney <bdud...@mac.com>
Subject Re: [jira] Commented: (MYFACES-628) Current Lifecycle implementation violates JSF Spec 1.1
Date Mon, 03 Oct 2005 21:11:03 GMT
Hi Ronald,

Just FYI, you don't have to have Eclipse up and running to get a  
myfaces-all.jar. Simply checkout the code with SVN and issue an 'ant  
dist-all' command from the build directory. In the end you will have  
a myfaces-all.jar file in the build/dist directory.

HTH.

-bd-

On Oct 3, 2005, at 1:42 PM, Ronald Brill (JIRA) wrote:

>     [ http://issues.apache.org/jira/browse/MYFACES-628? 
> page=comments#action_12331215 ]
>
> Ronald Brill commented on MYFACES-628:
> --------------------------------------
>
> Hi Bill,
>
> i finaly setup eclipse+subversion and the whole rest. (devours all  
> my spare time for the last days :-(
>
> But at the end i was able to make my own build including your  
> changes from today.
> Your implementation solves my problem, bit it works not correct in  
> terms of the specification.
>
> Sec says:
> 'If the FacesContext.responseComplete() method has been called  
> during the
> processing of the current request, or we have just completed the  
> Render Response
> phase, perform no further phases of the request processing lifecycle.'
>
> Your implementation still calls the before listener of the Render  
> Response phase if the responseComplete() method is called before.
>
> Please fix this.
>
> ---------------------------------------------------------------------- 
> -----
> But i have another point with your implementation.
> One part of my job is to help other (jsf) projects to solve there  
> problems. So the debug output is one of the things i realy need.
> Please make the output a bit more informative.
>
> 1. Your log output will be the same if
>   - i'm leaving the phase after the before listener
>   - i'm leaving the phase after the after listener
>
> For me as an 'supporter' it will be realy helpfull to be able to  
> distinguish this two different cases directly from the log output.
>
> 2. This are samples of your current output...
>
> exiting render in restoreView (-->render response)
> or
> exiting render in render (--> response complete)
>
> What about
> Exiting phase 'ResoreView' after invoking the before listeners;  
> next phase is 'RenderResponse (reason getRenderResponse() returns  
> true)
> or
> Exiting phase 'RenderResponse before listeners; Lifecycle finished  
> (reason getResponseComplete() returns true)
>
> It will be really helpfull to have a bit more expressive text for  
> all the log output.
>
> So far for today.....
>
>
>> Current Lifecycle implementation violates JSF Spec 1.1
>> ------------------------------------------------------
>>
>>          Key: MYFACES-628
>>          URL: http://issues.apache.org/jira/browse/MYFACES-628
>>      Project: MyFaces
>>         Type: Bug
>>   Components: JSR-127
>>     Versions: 1.1.0
>>     Reporter: Holger Schimanski
>>     Assignee: Bill Dudney
>>     Priority: Blocker
>>      Fix For: 1.1.1
>>
>
>
>>
>> If a PhaseListener.beforePhase() calles FacesContext.renderResponse 
>> () or FacesContext.responseComplete(), then the LifeCycleImpl  
>> should not execute the functionality required for the current  
>> phase. (see JSF Spec 1.1 section 11-1 page 296f.)  LifeCycleImpl  
>> is not taking care about this.
>> This is important for us, because we'd like to make a redirect in  
>> the before render response phase. And at the moment an Illegal  
>> State exception is thrown, because the renderResponse is executed  
>> although responseComplete has been called.
>>
>
> -- 
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the  
> administrators:
>    http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see:
>    http://www.atlassian.com/software/jira
>
>


Mime
View raw message