myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "CONNER, BRENDAN \(SBCSI\)" <bc1...@sbc.com>
Subject RE: RC3: dependency on commons-lang
Date Wed, 19 Oct 2005 15:12:44 GMT
It's not a big deal as long as it's documented fully.  Our app had an
older version of commons-lang.jar, which caused it to fail after we had
updated our MyFaces JAR files.  This was a problem until we replaced our
commons-lang.jar file with commons-lang-2.1.jar.

The Getting Started page should be updated to reflect that we need to
have commons-lang-2.1.jar.

- Brendan

-----Original Message-----
From: Sean Schofield [mailto:sean.schofield@gmail.com] 
Sent: Tuesday, October 18, 2005 10:08 PM
To: MyFaces Development
Subject: Re: RC3: dependency on commons-lang


I agree with Bill on that one.  I was suprised to see that this
dependency had been introduced (after we had avoided it for so long)
but I don't think its a big deal.

sean

On 10/18/05, Bill Dudney <bdudney@mac.com> wrote:
> I respectfully disagree, there is no way I want us copying
> functionality from commons-lang into myfaces.
>
> -bd-
>
> On Oct 18, 2005, at 6:47 PM, Simon Kitching wrote:
>
> > Hi,
> >
> > Class org.apache.myfaces.custom.calendar.HtmlCalendarRenderer.java
> > has had a dependency on commons-lang added. This means that my app
> > which previously worked fine now fails with a NoClassDefFoundError.
> >
> > The dependency was introduced by r289859 (mmarinschek) on
2005-09-18.
> >
> > I would recommend removing dependencies on commons-lang if
> > possible. It's always nice for a library such as myfaces to keep
> > its dependencies as small as possible.
> >
> > I've searched for "org.apache.commons.lang" and found the following
> > classes currently depend on it:
> >
> >   HtmlCalendarRenderer (method EscapeUtils.escapeJavaScript)
> >   HtmlJsValueSetRenderer (same)
> >   JspStateManagerImpl  (EqualsBuilder and HashCodeBuilder)
> >
> > I think it's quite feasable for myfaces to copy this o.a.c.lang
> > functionality into the myfaces project.
> >
> >
> >
> > On the general topic of binary compatibility, may I recommend the
> > CLIRR project:
> >   http://clirr.sourceforge.net/
> > Given two jars it will tell you whether they are binary compatible
> > or not. It also generates a nice report of the API changes made
> > which can be useful for creating release notes.
> >
> > Regards,
> >
> > Simon
> >
>
>

Mime
View raw message