myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Dudney (JIRA)" <myfaces-...@incubator.apache.org>
Subject [jira] Commented: (MYFACES-622) HtmlSelectManyCheckbox rendering is flawed
Date Mon, 03 Oct 2005 19:10:49 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-622?page=comments#action_12331210 ] 

Bill Dudney commented on MYFACES-622:
-------------------------------------

Hi Ken,

Any chance we could get some automated tests that we could use to make sure things continue
to work as expected? A simple cactus test would probably be sufficient. I'd be glad to offer
some pointers on Cactus in a dev list thread if you need them.

I am generally opposed to introducing changes to the branch that are not strictly necessary
but the changes here seem to be localized so with a test I'd be OK with them.

> HtmlSelectManyCheckbox rendering is flawed
> ------------------------------------------
>
>          Key: MYFACES-622
>          URL: http://issues.apache.org/jira/browse/MYFACES-622
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.1
>     Reporter: Ken Weiner
>  Attachments: HtmlCheckboxRenderer.java-patch.txt
>
> I apologize, but the patch I submitted to add an attirbute "layoutWidth" was not adequately
tested, and I have discovered that the layoutWidth attribute does not have the desired effect
when the checkboxes are rendered with a pageDirection layout.  The checkboxes end up rendering
in a single vertical row not matter what the layoutWidth is.  Also for both pageDirection
and lineDirection, the markup is not properly formed.  The label tag appears twice for each
checkbox.
> I am now submitting another patch to HtmlCheckboxRenderer that fixes these issues.  I
have tested it with different amounts of checkboxes, different layoutWidths, and different
combinations of SelectItemGroups.  Sorry about the original being messed up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message