myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Marinschek (JIRA)" <>
Subject [jira] Closed: (MYFACES-505) Use writeComment() instead of write() for <script>
Date Mon, 05 Sep 2005 10:25:31 GMT
     [ ]
Martin Marinschek closed MYFACES-505:

    Fix Version: Nightly Build
     Resolution: Fixed

Thanks for this patch to Alexandr Smirnov. Also duplicate of MYFACES-158, but not the complete
resolution - all scripts under tomahawk need to be changed to use this behaviour as well.

> Use writeComment() instead of write() for <script>
> --------------------------------------------------
>          Key: MYFACES-505
>          URL:
>      Project: MyFaces
>         Type: Improvement
>   Components: Implementation
>  Environment: ALL
>     Reporter: Alexandr Smirnov
>     Assignee: Martin Marinschek
>     Priority: Minor
>      Fix For: Nightly Build
>  Attachments: HtmlRendererUtils.patch
> For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method
with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles
for creating XHTML output in future ( in most cases, all correct writed components can produce
valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method
for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction
in HtmlRendererUtils.
> attached patch replace write to writeComment for this function.
> Also, in Tomahawk components have many places for commented scripts & styles.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
For more information on JIRA, see:

View raw message