myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Marinschek (JIRA)" <myfaces-...@incubator.apache.org>
Subject [jira] Commented: (MYFACES-505) Use writeComment() instead of write() for <script>
Date Mon, 05 Sep 2005 09:27:30 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-505?page=comments#action_12322649 ] 

Martin Marinschek commented on MYFACES-505:
-------------------------------------------

You are right - thanks for the patch. Even though this issue is a duplicate of MYFACES-158.
Let's apply the patch and then close this out as duplicate!

regards,

Martin

> Use writeComment() instead of write() for <script>
> --------------------------------------------------
>
>          Key: MYFACES-505
>          URL: http://issues.apache.org/jira/browse/MYFACES-505
>      Project: MyFaces
>         Type: Improvement
>   Components: Implementation
>  Environment: ALL
>     Reporter: Alexandr Smirnov
>     Priority: Minor
>  Attachments: HtmlRendererUtils.patch
>
> For creating in-page scripts, MyFaces implementation use RsponceWriter.write() method
with "<!-- " and "-->" strings. It not important in HTML_BASIC , but may produce troubles
for creating XHTML output in future ( in most cases, all correct writed components can produce
valid XHTML. ). For such reasons, more correct will be use ResponseWriter.writeComment method
for scripts & styles. In implementation, single place for in-page script prodution - renderClearHiddenCommandFormParamsFunction
in HtmlRendererUtils.
> attached patch replace write to writeComment for this function.
> Also, in Tomahawk components have many places for commented scripts & styles.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message