myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erik-Berndt Scheper (JIRA)" <myfaces-...@incubator.apache.org>
Subject [jira] Commented: (MYFACES-562) <t:commandSortHeader> processes action / actionListener before updating values of sortColumn and sortAscending
Date Tue, 27 Sep 2005 14:20:54 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-562?page=comments#action_12330592 ] 

Erik-Berndt Scheper commented on MYFACES-562:
---------------------------------------------

My mistake, wrong cut & paste...
It should have been something like:
 
<t:dataTable id="data" sortColumn="#{pagedSort.sort}" sortColumnAscending="#{pagedSort.ascending}"
...   >
	<t:column>
		<f:facet name="header">
			<t:commandSortHeader columnName="name" immediate="false" actionListener="#{pagedSort.sortActionListener}">
				<f:facet name="ascending">
					<h:graphicImage url="/images/arrow-asc.gif" style="border:none"/>
				</f:facet>
				<f:facet name="descending">
					<h:graphicImage url="/images/arrow-desc.gif" style="border:none"/>
				</f:facet>
				<h:outputText value="#{msg['label.naam']}" />
			</t:commandSortHeader>
		</f:facet>
		<h:outputText value="#{employee.name}" />
	</t:column>
..
</t:dataTable>

The problem is that the actionListener of the sortHeader tag (method sortActionListener()
of pagedSort.java) is called before the properties "#{pagedSort.sort}" and "#{pagedSort.ascending}"
have been updated.

> <t:commandSortHeader> processes action / actionListener before updating values
of sortColumn and sortAscending
> --------------------------------------------------------------------------------------------------------------
>
>          Key: MYFACES-562
>          URL: http://issues.apache.org/jira/browse/MYFACES-562
>      Project: MyFaces
>         Type: Bug
>   Components: Tomahawk
>     Versions: 1.1.0
>     Reporter: Erik-Berndt Scheper

>
> At the moment <t:CommandSortHeader> processes an action / actionListener before
updating the values of sortColumn and sortAscending. The reason is that in the broadcast()
 method of HtmlCommandSortHeader.java, the method super.broadcast(event) is executed before
the values are updated.
> The consequence of this bug is that in the methods called by the action / actionListener,
the sortColumn and sortAscending properties of the datatable still have the old value. Which
in turn means that any sorting performed in the action / actionListener methods lead to incorrect
results.
> Suggested solution: call super.broadcast(event) AFTER the values of the datatable have
been updated.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message