myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Martin Marinschek (JIRA)" <myfaces-...@incubator.apache.org>
Subject [jira] Commented: (MYFACES-444) HtmlMessageRendererBase renders tooltip as message summary rather than detail
Date Mon, 29 Aug 2005 03:57:08 GMT
    [ http://issues.apache.org/jira/browse/MYFACES-444?page=comments#action_12320383 ] 

Martin Marinschek commented on MYFACES-444:
-------------------------------------------

Ken is checking with the JSF-RI/Spec what to do with this documentation bug.

I set this to "in progress" in the meantime.

regards,

Martin

> HtmlMessageRendererBase renders tooltip as message summary rather than detail
> -----------------------------------------------------------------------------
>
>          Key: MYFACES-444
>          URL: http://issues.apache.org/jira/browse/MYFACES-444
>      Project: MyFaces
>         Type: Bug
>   Components: JSF 1.1
>     Versions: 1.0.9 beta
>     Reporter: Ken Weiner
>     Assignee: Martin Marinschek

>
> The tooltip attribute description on http://java.sun.com/j2ee/javaserverfaces/1.1/docs/tlddocs/h/message.html
says that the tooltip content should be composed of the message detail text.  However, the
tooltip content in MyFaces is getting set to the message summary text.  This happens in HtmlMessageRendererBase
in the renderSingleFacesMessage() method.  The code sets the title to the summary if the tooltip
is enabled.  Otherwise it uses the title attribute:
>         String summary = getSummary(facesContext, message, facesMessage, messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (title == null && tooltip)
>         {
>             title = summary;
>         }
> Instead it should use the detail as follows:
>         String summary = getSummary(facesContext, message, facesMessage, messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (title == null && tooltip)
>         {
>             title = detail;
>         }
> It might be argued that the tooltip should be set to the detail regardless of whether
the title attribute is set at all since the description of the title attribute is "Advisory
title information about markup elements generated for this component."  If that is the case
then the code should look like this:
>         String summary = getSummary(facesContext, message, facesMessage, messageClientId);
>         String detail = getDetail(facesContext, message, facesMessage, messageClientId);
>         String title = getTitle(message);
>         boolean tooltip = isTooltip(message);
>         if (tooltip)
>         {
>             title = detail;
>         }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message