Mailing-List: contact dev-help@myfaces.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "MyFaces Development" <dev@myfaces.apache.org>
Received-SPF: pass (asf.osuosl.org: domain of mkienenb@gmail.com designates
 64.233.184.197 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=DgoeHcKPV1OmA2MZP5+Q/vQXw9w6ULv0NAhHDuPgN1qjW1oaA/dqwvTnInnAkAGLH/OCpc4qQhCgpSCRpnxpRGT3lakB+1HxolfA9VGHx/RT2s1oJZxkvoa4/N37+LM3L6AdtmzbXb48YY0mbWh8qbevDv0rsN0kgjbQDiyP7q8=
Message-ID: <8f985b96050721093230fc07bc@mail.gmail.com>
Date: Thu, 21 Jul 2005 12:32:16 -0400
From: Mike Kienenberger <mkienenb@gmail.com>
Reply-To: Mike Kienenberger <mkienenb@gmail.com>
To: MyFaces Development <dev@myfaces.apache.org>
Subject: Re: [proposal] use EasyMock for mocking
In-Reply-To: <2D4D3136-B487-4A76-93B7-B576C2B74097@mac.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <42DE8BB6.2060909@marathon-man.com>
	 <F426F693-3833-4A2D-B2AD-47886D867389@mac.com>
	 <37C11EBB-B525-4294-A814-14C8733BB8CB@mac.com>
	 <42DFBC8C.6050100@marathon-man.com>
	 <8DBB42CF-2875-411A-BE13-5854B76107F9@mac.com>
	 <8f985b96050721091255ac92cd@mail.gmail.com>
	 <2D4D3136-B487-4A76-93B7-B576C2B74097@mac.com>

If all users were like me (permanent broadband connection), I'd agree :)
Remember that some folks don't want the source to do development, they
just have a requirement that all things must be built from source. =20
Now, I'd think you'd also want to test it after the build, but again,
that's just me.   I don't think there should be a requirement to force
someone to do it.

If there's already a target to download build dependencies, I can't
see how it's all that much harder to also have one that only downloads
testing dependencies.

On 7/21/05, Bill Dudney <bdudney@mac.com> wrote:
> Hi Mike,
>=20
> I understand the point that it could take longer for slower connections.
>=20
> However, again IMO, if someone is doing development on myfaces they
> should be doing testing.
>=20
> And also IMO as a user of other projects I like to have a test target
> that I can use when building others software so I can have some level
> of assurance that the build worked. I actually prefer to have that be
> part of the dist type target but that consensus does not exist among
> the rest of the team so I'm not pushing it.
>=20
> If the rest of the team want's a separate download target for getting
> the testing stuff I'm fine with that too.
>=20
> My $0.02 worth.
>=20
> TTFN,
>=20
> -bd-
>=20
> On Jul 21, 2005, at 10:12 AM, Mike Kienenberger wrote:
>=20
> > It takes 20 seconds for you to download them.
> > That doesn't mean it takes 20 seconds for others.
> > If they're only used for testing, don't download them unless you're
> > doing testing.
> > Testing dependencies tend to grow in large projects.
> >
> > On 7/21/05, Bill Dudney <bdudney@mac.com> wrote:
> >
> >> OK I've committed the changes.
> >>
> >> On the download dependencies, there is no real reason not to just
> >> download them (IMO) because it takes an additional 20 seconds the
> >> first time and then an additional 1 second thereafter (I made up the
> >> #'s but its not far off) so I'd just as soon not complicate matters
> >> by adding another target to download test dependencies.
> >>
> >> Next up is Cactus :-)
> >>
> >> TTFN,
> >>
> >> -bd-
> >>
> >> On Jul 21, 2005, at 9:17 AM, Grant Smith wrote:
> >>
> >>
> >>> +1 for EasyMock and it's dependencies. While we're at it, don't we
> >>> need junit.jar too ? Also, I would recommend only downloading the
> >>> dependencies if you run the 'test-all' (or 'test' for a subproject)
> >>> target, not if you run the usual 'dist-all' that most people will
> >>> be doing.
> >>>
> >>> Thanks for doing this Bill !!
> >>>
> >>> Bill Dudney wrote:
> >>>
> >>>
> >>>
> >>>> Hi All,
> >>>>
> >>>> I've got the first of the EasyMock (http://www.easymock.org) tests
> >>>> in  place. I have not commited the changes because I wanted to
> >>>> get  everyone's opinion before introducing a new dependency. There
> >>>> are 4  new jars required to use easymock, ams.jar, cglib.jar,
> >>>> easymock- classextensions.jar and easymock.jar. The cglib and ams
> >>>> dependency  are used to mock abstract classes (the default
> >>>> easymock.jar is able  to mock interfaces without cglib or ams).
> >>>>
> >>>> With the EasyMock framework I was able to get to 100% code
> >>>> coverage  of the abstract StateManager class with 5 tests and less
> >>>> than 125  lines of actual test code. I'm a fan and have used it
> >>>> extensively on  other projects. I believe the extra dependencies
> >>>> are worth it to get  the testing done.
> >>>>
> >>>> As soon as there is consensus I'll commit the changes to
> >>>> build.xml  and the actual test code (or by tomorrow afternoon or
> >>>> so assuming  that a lack of comment is agreement) then move on to
> >>>> the cactus test  stuff.
> >>>>
> >>>> Sean: I'll try a couple of different approaches to the build and
> >>>> post  in the form of a proposal, so your feedback to that thread
> >>>> will be  most useful :-)
> >>>>
> >>>> TTFN,
> >>>>
> >>>> -bd-
> >>>>
> >>>>
> >>>
> >>>
> >>>
> >>>
> >>
> >>
> >
>=20
>