myfaces-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Howard Abrams (JIRA)" <incubator-...@incubator.apache.org>
Subject [jira] Updated: (MYFACES-116) validate API does not match spec/RI
Date Fri, 04 Mar 2005 00:03:55 GMT
     [ http://issues.apache.org/jira/browse/MYFACES-116?page=history ]

Howard Abrams updated MYFACES-116:
----------------------------------

    Attachment: validate.patch

This is an untested patch. I do not have a working cvs/build environment.

> validate API does not match spec/RI
> -----------------------------------
>
>          Key: MYFACES-116
>          URL: http://issues.apache.org/jira/browse/MYFACES-116
>      Project: MyFaces
>         Type: Bug
>     Versions: 1.0.8 beta
>     Reporter: Howard Abrams
>  Attachments: validate.patch
>
> In the reference implementation, UIInput has a protected method 'validateValue'. By default
it does some basic checks including checking the 'required' property, calling the validators,
etc. It can be overridden without messing with the basics of validation (getting the converted
value, firing a valueChange event, etc). In myFaces, this has all been lumped into 'validate'.
This means to tweak the validation of a custom component based on UIInput, you must re-implement
all of 'validate', including all the basics. To make matters worse, 'getConvertedValue' is
private in myFaces (it is protected in the RI), so you must re-implement all of that method
as well (and call it something else).  
> According to the 1.1 spec, 'validate' must "Perform the algorithm described in the javadoc
to validate the local value of this UIInput", and the 1.1 javadoc. The javadoc in-turn mentions
'validateValue', etc, etc.
> The following changes should be made:
> 1. Add a protected method 'validateValue', and change the 'validate'
> implementation to use it
> 2. Change 'getConvertedValue' from private to protected
> 3. Remove 'validate' from UISelectMany and move needed functionality to 'validateValue'.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


Mime
View raw message