myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mat...@apache.org
Subject svn commit: r830381 - /myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
Date Tue, 27 Oct 2009 22:37:47 GMT
Author: matzew
Date: Tue Oct 27 22:37:46 2009
New Revision: 830381

URL: http://svn.apache.org/viewvc?rev=830381&view=rev
Log:
MYFACES-2389 - clean up the UIComponentBase.setParent()
did some more clean-up...

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java?rev=830381&r1=830380&r2=830381&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIComponentBase.java Tue Oct
27 22:37:46 2009
@@ -201,6 +201,8 @@
             // PostAddToViewEvent could cause component relocation
             // (h:outputScript, h:outputStylesheet, composite:insertChildren, composite:insertFacet)
             // so we need to check if the component was relocated or not
+          
+            // is this all really needed ?
             List<UIComponent> children = component.getChildren();
             UIComponent child = null;
             UIComponent currentChild = null;
@@ -230,7 +232,7 @@
     }
     
     /**
-     * Publish PostAddToViewEvent to the component and all facets and children.
+     * Publish PreRemoveFromViewEvent to the component and all facets and children.
      * 
      * @param context
      * @param component
@@ -256,28 +258,6 @@
         }        
     }    
     
-    private static void _updateChild(UIComponent component, boolean isInView)
-    {
-        if (component.getChildCount() > 0)
-        {
-            for (UIComponent child : component.getChildren())
-            {
-                child.setInView(isInView);
-                //recursive call to set to all descendants
-                _updateChild(child, isInView);
-            }
-        }
-        if (component.getFacetCount() > 0)
-        {
-            for (UIComponent child : component.getFacets().values())
-            {
-                child.setInView(isInView);
-                //recursive call to set to all descendants
-                _updateChild(child, isInView);
-            }
-        }         
-    }
-
     /**
      * 
      * @param eventName
@@ -1154,6 +1134,8 @@
             {
                 it.next().processValidators(context);
             }
+            
+            popComponentFromEL(context);
         }
     }
 



Mime
View raw message