myfaces-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dennisby...@apache.org
Subject svn commit: r373283 - in /myfaces: core/trunk/api/src/main/java/javax/faces/component/ core/trunk/api/src/main/java/javax/faces/convert/ tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/
Date Sun, 29 Jan 2006 03:57:11 GMT
Author: dennisbyrne
Date: Sat Jan 28 19:57:06 2006
New Revision: 373283

URL: http://svn.apache.org/viewcvs?rev=373283&view=rev
Log:
MYFACES-1049 - patch from Dennis Byrne

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
    myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectMany.java
    myfaces/core/trunk/api/src/main/java/javax/faces/convert/DateTimeConverter.java
    myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/DateTimeConverter.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java
URL: http://svn.apache.org/viewcvs/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?rev=373283&r1=373282&r2=373283&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java Sat Jan 28 19:57:06
2006
@@ -342,7 +342,7 @@
         Object previousValue = getValue();
         setValue(convertedValue);
         setSubmittedValue(null);
-        if (valuesDifferent(previousValue, convertedValue))
+        if (compareValues(previousValue, convertedValue))
         {
             queueEvent(new ValueChangeEvent(this, previousValue, convertedValue));
         }
@@ -406,7 +406,7 @@
 
 
 
-    protected boolean valuesDifferent(Object previous,
+    protected boolean compareValues(Object previous,
                                       Object value)
     {
         return previous==null?(value!=null):(!previous.equals(value));

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectMany.java
URL: http://svn.apache.org/viewcvs/myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectMany.java?rev=373283&r1=373282&r2=373283&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectMany.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/component/UISelectMany.java Sat Jan 28
19:57:06 2006
@@ -81,7 +81,7 @@
     /**
      * @return true if Objects are different (!)
      */
-    protected boolean valuesDifferent(Object previous, Object value)
+    protected boolean compareValues(Object previous, Object value)
     {
         if (previous == null)
         {

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/convert/DateTimeConverter.java
URL: http://svn.apache.org/viewcvs/myfaces/core/trunk/api/src/main/java/javax/faces/convert/DateTimeConverter.java?rev=373283&r1=373282&r2=373283&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/convert/DateTimeConverter.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/convert/DateTimeConverter.java Sat Jan
28 19:57:06 2006
@@ -53,7 +53,7 @@
     private Locale _locale;
     private String _pattern;
     private String _timeStyle;
-    protected TimeZone _timeZone;
+    private TimeZone _timeZone;
     private String _type;
     private boolean _transient;
 

Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/DateTimeConverter.java
URL: http://svn.apache.org/viewcvs/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/DateTimeConverter.java?rev=373283&r1=373282&r2=373283&view=diff
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/DateTimeConverter.java
(original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/convertDateTime/DateTimeConverter.java
Sat Jan 28 19:57:06 2006
@@ -16,8 +16,6 @@
 
 package org.apache.myfaces.custom.convertDateTime;
 
-import javax.faces.context.FacesContext;
-import javax.faces.component.UIComponent;
 import java.util.TimeZone;
 
 /**
@@ -33,22 +31,9 @@
 {
     public static final String CONVERTER_ID = org.apache.myfaces.custom.convertDateTime.DateTimeConverter.class.getName();
 
-    public TimeZone getTimeZone()
+    public DateTimeConverter()
     {
-        return _timeZone != null ? _timeZone : TimeZone.getDefault();
-    }
-
-    public String getAsString(FacesContext facesContext, UIComponent uiComponent, Object
value)
-    {
-        String s = super.getAsString(facesContext, uiComponent, value);
-        return s;
-    }
-
-    // METHODS
-    public Object getAsObject(FacesContext facesContext, UIComponent uiComponent, String
value)
-    {
-        Object ob = super.getAsObject(facesContext, uiComponent, value);
-        return ob;
+        setTimeZone(TimeZone.getDefault());
     }
 
 }



Mime
View raw message