mxnet-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-mxnet] zjost commented on issue #19323: Variable sequence length not handled correctly for BiDirectional layers
Date Thu, 15 Oct 2020 15:57:53 GMT

zjost commented on issue #19323:
URL: https://github.com/apache/incubator-mxnet/issues/19323#issuecomment-709422989


   Thanks for taking the time to show an implementation of this.
   
   Do you think a warning should be added to the documentation regarding the use of `bidirectional`?
 I don't think it's clear that this will not have intended behavior unless sequences are of
equal length in a batch.  Particularly so because if you start tracing down the base classes,
it seems as though e.g. GRU will pass along the `use_sequence_length` kwarg.
   
   Regarding #14208, I'm not sure why this fails for other RNN types since the code changes
appear to be primarily to the `_RNN` base class rather than the LSTMCell.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@mxnet.apache.org
For additional commands, e-mail: issues-help@mxnet.apache.org


Mime
View raw message