From dev-return-7970-archive-asf-public=cust-asf.ponee.io@mxnet.apache.org Wed Aug 19 18:46:29 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mailroute1-lw-us.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id 6A9EA18062C for ; Wed, 19 Aug 2020 20:46:29 +0200 (CEST) Received: from mail.apache.org (localhost [127.0.0.1]) by mailroute1-lw-us.apache.org (ASF Mail Server at mailroute1-lw-us.apache.org) with SMTP id 3EA6D125886 for ; Wed, 19 Aug 2020 18:46:28 +0000 (UTC) Received: (qmail 49752 invoked by uid 500); 19 Aug 2020 18:46:27 -0000 Mailing-List: contact dev-help@mxnet.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.apache.org Delivered-To: mailing list dev@mxnet.apache.org Received: (qmail 49697 invoked by uid 99); 19 Aug 2020 18:46:27 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Aug 2020 18:46:27 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D25161A4282 for ; Wed, 19 Aug 2020 18:46:26 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.65 X-Spam-Level: X-Spam-Status: No, score=-0.65 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.25, HTML_IMAGE_ONLY_32=0.001, HTML_MESSAGE=0.2, MAILING_LIST_MULTI=-1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (1024-bit key) header.d=github.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id tZC9M5y6-QT4 for ; Wed, 19 Aug 2020 18:46:25 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::12e; helo=mail-lf1-x12e.google.com; envelope-from=dmlc.notification+caf_=dev=mxnet.apache.org@gmail.com; receiver= Received: from mail-lf1-x12e.google.com (mail-lf1-x12e.google.com [IPv6:2a00:1450:4864:20::12e]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id E8A477FBC3 for ; Wed, 19 Aug 2020 18:46:24 +0000 (UTC) Received: by mail-lf1-x12e.google.com with SMTP id b11so12617075lfe.10 for ; Wed, 19 Aug 2020 11:46:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:delivered-to:dkim-signature:date:from:reply-to :to:cc:message-id:in-reply-to:references:subject:mime-version :content-transfer-encoding:precedence:list-id:list-archive:list-post :list-unsubscribe; bh=VaUQ7wOV+w1TyAl5Kk0itx0mRnOxMJ+vCG1DFOUoeU0=; b=WUYKA5hElG/+Ekqo+unMb7Y0WEw86B+JkSWwuDmNUQPkWrw2ihsYiovqWNsWon14Pq DroA8GO9QrmsjmIAUJZyobN+8qJmj9ve3C4LQEes0bzdWaBdlo/Y+1415DNQJSlmCmGR GemypOXceqKFoohjib2Nh47kluPB74iChmnZrAH+hAsldfBF8OQWT/iWX77XqBIqfCfZ OvfhhteRVaCGKOFQN111Fjdte5fMJ9iGNFPmy9CIkgHvqwi+7hWmUML/HPbs9spde5Fa 2MoNDWFxVHzYzttRVEur9+sH3PiCt6ytmziJf/slPuCXzN5mot4SMj+oiQOYYyupzpE1 A3Cg== X-Gm-Message-State: AOAM532wjbmrBFY8U8hHJqYQpxSPjWaMwrdB3w6aIOojTRrSpU904KHz /ceS+iw41CYNvtfjF1/sc49pW5Qaq77X18Qf1s+dIzP3VhO5HBU4HA== X-Received: by 2002:a05:6512:20c1:: with SMTP id u1mr12759963lfr.17.1597862783912; Wed, 19 Aug 2020 11:46:23 -0700 (PDT) X-Forwarded-To: dev@mxnet.apache.org X-Forwarded-For: dmlc.notification@gmail.com dev@mxnet.apache.org Delivered-To: dmlc.notification@gmail.com Received: by 2002:ab3:1114:0:0:0:0:0 with SMTP id j20csp683485lta; Wed, 19 Aug 2020 11:46:22 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxC559DCCpytKF6KXhwDApmm/ANwkltxe12sVfEsyhxI/2CRdqf+lsjjFDo2ADKE4+/RjsH X-Received: by 2002:a0c:dd05:: with SMTP id u5mr24774383qvk.143.1597862782005; Wed, 19 Aug 2020 11:46:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597862782; cv=none; d=google.com; s=arc-20160816; b=AuQrijLPfKGFS7qAy4QbDA90FhUIsTpkhNzyaJQavhyrrxBJU5zNcPP45ORM3CKnGM phtsE/Sfn5i8ZELf9lkHSH6tSpjzxB62I9wqWvq6vls5ZSJyWa+iW1y2cCzrMHupxFGt qhFRFei12K+2zC+vuAemwTQ1xvRaCz/sF8R+AUKCwwRKC5FulS/3a4SA7cT2n+3B6IOl mZAseCZdwNvbXl5GwAaM0UF/qPZHa2/afdLAN3dydRxXR+zT8sRzmHV7ibecG1wlMsn0 tnthNttNu46pWoRVFr9sX5dUyUTr3X3NceGAsHRvigLPf+8oOos0S3al1RkUJ5shrDNU Y0Vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-post:list-archive:list-id:precedence :content-transfer-encoding:mime-version:subject:references :in-reply-to:message-id:cc:to:reply-to:from:date:dkim-signature; bh=VaUQ7wOV+w1TyAl5Kk0itx0mRnOxMJ+vCG1DFOUoeU0=; b=sexSUhMPn/Xxu29Xkkj+tiiAfsoPg4ynDsTGHyXtG42cC0ZZlEvwkns31x3fyHoQsf AGW8yz1rPIGI+SaHDyEuj1jQHZu/dosLMdljt4AN6TllhrtUJGPrcdiit7Bpp0dQKLHl z9kulj2suWsy8/gJakyXubWVJfRS41fANol+kA4UXGsrlL8ccWW9VstoQCnebJSmijn7 ioKPXe3yGAuikyv30/luK9Hac6jGWUfeTILV52cAnFvnWuFJbsNleYMyW/pDZebmuik3 bI5sjtCUgSLH9qTNCjnnUP0icDEKfvWYTSajSxqF2XozSVoECTh7hF2QaJHgXKsHT0NE v69g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@github.com header.s=pf2014 header.b=W+V7y4qI; spf=pass (google.com: domain of noreply@github.com designates 192.30.252.204 as permitted sender) smtp.mailfrom=noreply@github.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=github.com Received: from out-21.smtp.github.com (out-21.smtp.github.com. [192.30.252.204]) by mx.google.com with ESMTPS id z91si16550542qtd.299.2020.08.19.11.46.21 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Aug 2020 11:46:21 -0700 (PDT) Received-SPF: pass (google.com: domain of noreply@github.com designates 192.30.252.204 as permitted sender) client-ip=192.30.252.204; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@github.com header.s=pf2014 header.b=W+V7y4qI; spf=pass (google.com: domain of noreply@github.com designates 192.30.252.204 as permitted sender) smtp.mailfrom=noreply@github.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=github.com Received: from github-lowworker-bb778fb.ash1-iad.github.net (github-lowworker-bb778fb.ash1-iad.github.net [10.56.102.56]) by smtp.github.com (Postfix) with ESMTP id 9FAFE520D80 for ; Wed, 19 Aug 2020 11:46:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=github.com; s=pf2014; t=1597862781; bh=VaUQ7wOV+w1TyAl5Kk0itx0mRnOxMJ+vCG1DFOUoeU0=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:List-ID: List-Archive:List-Post:List-Unsubscribe:From; b=W+V7y4qI6fNubVSNB421p1M2lqqxOgSeMS+DaE9tCIuDR0x0X47YKurBkPEMhvSqJ 18ue+sharvdEbIGrW7JA4FQhYNfiCeN0+swUlZ9Hbr30cOM1/M68TBL3Zq1dMMVGry +TzfcviZcWL9RVwmClqvrtOBvJNm9usrp5yq6egk= Date: Wed, 19 Aug 2020 11:46:21 -0700 From: Xingjian Shi Reply-To: apache/incubator-mxnet To: apache/incubator-mxnet Cc: Sheng Zha , Mention Message-ID: In-Reply-To: References: Subject: Re: [apache/incubator-mxnet] [Development] MXNet 2.0 Update (#18931) Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="--==_mimepart_5f3d737d903c3_2c40196410279f"; charset=UTF-8 Content-Transfer-Encoding: 7bit X-GitHub-Sender: sxjscience X-GitHub-Recipient: szha X-GitHub-Reason: mention List-Archive: https://github.com/apache/incubator-mxnet X-Auto-Response-Suppress: All X-GitHub-Recipient-Address: dmlc.notification@gmail.com ----==_mimepart_5f3d737d903c3_2c40196410279f Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit @StevenJokes In addition, for the DCGAN issue that is related to D2L, a simple way to verify that you are correct (and also convince the others), is to write a test case that checks whether these two networks are **equivalent**. For example, you have a network A implemented in MXNet and a network B implemented in PyTorch. There are several checks that you can do: - Just try to see if these two networks have the same number of parameters - Do a forward pass of both networks and check whether the outputs are the same. - Do a forward + backward and match the gradient. Usually, you will need to do more to convince the others that certain issues exist. There are some examples: - Here, the minimal reproducible example related to Autograd helps us locate the problem: https://github.com/apache/incubator-mxnet/issues/17989 - A minimal example that captures a potential issue of the GELU implementation in MKLDNN https://github.com/apache/incubator-mxnet/issues/18826 It will be a good practice if you can write such test cases and tell D2L people. -- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/apache/incubator-mxnet/issues/18931#issuecomment-676597008 ----==_mimepart_5f3d737d903c3_2c40196410279f--