From dev-return-7726-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Sun Jul 5 17:09:08 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C6E95180652 for ; Sun, 5 Jul 2020 19:09:07 +0200 (CEST) Received: (qmail 57188 invoked by uid 500); 5 Jul 2020 17:09:07 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 57176 invoked by uid 99); 5 Jul 2020 17:09:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Jul 2020 17:09:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 3ED471A32F2 for ; Sun, 5 Jul 2020 17:09:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -12.991 X-Spam-Level: X-Spam-Status: No, score=-12.991 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_DMARC_STATUS=0.01, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5] autolearn=disabled Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id Lp-0HlA_9lqr for ; Sun, 5 Jul 2020 17:09:04 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=207.244.88.153; helo=mail.apache.org; envelope-from=mjwall@apache.org; receiver= Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with SMTP id 30524BB91F for ; Sun, 5 Jul 2020 17:09:04 +0000 (UTC) Received: (qmail 57156 invoked by uid 99); 5 Jul 2020 17:09:04 -0000 Received: from Unknown (HELO mailrelay1-lw-us.apache.org) (10.10.3.159) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 Jul 2020 17:09:04 +0000 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id D850840B70 for ; Sun, 5 Jul 2020 17:09:03 +0000 (UTC) Received: by mail-qv1-f50.google.com with SMTP id m8so12039604qvk.7 for ; Sun, 05 Jul 2020 10:09:03 -0700 (PDT) X-Gm-Message-State: AOAM532SeG1PAZMQoDKnvZFfS0LvVcXEtEHQXWl4w+sRYfTAhdlOYV4j opOviy1z/1vG1Sa9aKVvQSbcei71SACWXZt7hg== X-Google-Smtp-Source: ABdhPJyVWcp1WRoukz4LQtkEU6bDON3b0kuYJypdWXwcrzGi3sbSwR2Y6eXVSJCKowbzUYPBJeJyeaSfv/xW8fcp/7U= X-Received: by 2002:ad4:4112:: with SMTP id i18mr42346804qvp.109.1593968943395; Sun, 05 Jul 2020 10:09:03 -0700 (PDT) MIME-Version: 1.0 References: <4983F978-AA4D-4F88-8541-4958F00ACBA5@gmail.com> In-Reply-To: <4983F978-AA4D-4F88-8541-4958F00ACBA5@gmail.com> From: Michael Wall Date: Sun, 5 Jul 2020 13:08:52 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: assimilation of mshadow into the MXNet codebase To: dev@mxnet.incubator.apache.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, to secretary@. Do you need a template? Thanks Sheng Mike On Sun, Jul 5, 2020 at 12:59 PM Sheng Zha wrote: > > Hi Michael, > > Thanks for offering help. I can represent the code donors and file the so= ftware grant. Should the filing go to secretary@? > > Sheng > > > On Jul 5, 2020, at 9:50 AM, Michael Wall wrote: > > > > =EF=BB=BFIs this being tracked in a ticket anywhere? What help can I o= ffer? > > > > Mike > > > >> On Fri, Jun 12, 2020 at 6:44 PM Marco de Abreu wrote: > >> > >> Hi Sheng, > >> > >> since this is a "large one off code contribution", the policy [1] stat= es > >> that they should be brought in through a software grant. > >> > >> Best regards, > >> Marco > >> > >> [1]: https://www.apache.org/foundation/how-it-works/legal.html > >> > >>> On Fri, Jun 12, 2020 at 11:41 PM Sheng Zha wrot= e: > >>> > >>> To mentors, > >>> > >>> Do we the PPMC need to fill out IP clearance for this code donation? > >>> > >>> -sz > >>> > >>> On 2019/04/24 21:19:49, Sheng Zha wrote: > >>>> The community has agreed to donate mshadow to the mxnet code base. I > >>> will start the migration and build logic changes soon. > >>>> > >>>> -sz > >>>> > >>>> On 2019/04/07 21:47:39, Sheng Zha wrote: > >>>>> I agree it would make development easier to donate mshadow to mxnet > >>> code base, since mshadow is only used in MXNet. I support donating th= e > >>> mshadow code to mxnet and I started an RFC for this in mshadow [1]. > >>>>> > >>>>> [1] https://github.com/dmlc/mshadow/issues/373 > >>>>> > >>>>> -sz > >>>>> > >>>>> On 2019/04/06 04:38:19, Tianqi Chen wrot= e: > >>>>>> Technically, mshadow is sufficient for MXNet. Adopting other > >>> libraries ( > >>>>>> eigen or xtensor) will unnecessarily increase the codebase complex= ity > >>>>>> without any additional gains. > >>>>>> > >>>>>> Given that mshadow is only used by mxnet. I do support donating it > >>> into > >>>>>> mxnet codebase. > >>>>>> To respect the original mshadow community. I would recommend > >>> starting a > >>>>>> community RFC In the mshadow github issue for a week, before we > >>> start the > >>>>>> migrating process. > >>>>>> Also, I would recommend a rebase merge just like the case of > >>> MXNet.jl code > >>>>>> base to preserve the contribution history. > >>>>>> > >>>>>> Tianqi > >>>>>> > >>>>>> > >>>>>> On Fri, Apr 5, 2019 at 9:25 PM Alfredo Luque > >>>>>> wrote: > >>>>>> > >>>>>>> Do you have a link to both of these proposals? > >>>>>>> > >>>>>>> On Fri, Apr 5, 2019 at 20:14 Anirudh Acharya < > >>> anirudhkrec@gmail.com> > >>>>>>> wrote: > >>>>>>> > >>>>>>>> Hi Pedro, > >>>>>>>> > >>>>>>>> mshadow is mostly used for tensor arithmetic. There have been > >>> discussions > >>>>>>>> about including it within mxnet. I think it is a good idea. > >>>>>>>> > >>>>>>>> As a more long term solution using libraries like eigen to > >>> perform linear > >>>>>>>> algebra operations was also suggested by anirudh2290@. I think > >>> xtensor( > >>>>>>>> https://github.com/QuantStack/xtensor ) can also be a candidate > >>> here. > >>>>>>>> > >>>>>>>> - > >>>>>>>> Anirudh > >>>>>>>> > >>>>>>>> > >>>>>>>> On Fri, Apr 5, 2019 at 7:03 PM Pedro Larroy < > >>>>>>> pedro.larroy.lists@gmail.com> > >>>>>>>> wrote: > >>>>>>>> > >>>>>>>>> Hi > >>>>>>>>> > >>>>>>>>> Some developers have noticed that working in mshadow is > >>> cumbersome as > >>>>>>>>> it's a 3rdparty subrepo. > >>>>>>>>> > >>>>>>>>> Since mshadow is a bunch of headers which don't have much of > >>>>>>>>> independent tests / library functionality, me and other > >>> developers > >>>>>>>>> believe that it would be good to assimilate this code in the > >>>>>>>>> repository for ease of contribution and changes without having > >>> to go > >>>>>>>>> trough contortions to test PRs that modify mshadow. > >>>>>>>>> > >>>>>>>>> Would anybody oppose this change? > >>>>>>>>> > >>>>>>>>> Thanks and have a nice weekend. > >>>>>>>>> > >>>>>>>>> Pedro. > >>>>>>>>> > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>>> > >>>