From dev-return-6986-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Sat Dec 7 11:30:34 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4055618065B for ; Sat, 7 Dec 2019 12:30:34 +0100 (CET) Received: (qmail 67364 invoked by uid 500); 7 Dec 2019 11:30:33 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 67352 invoked by uid 99); 7 Dec 2019 11:30:33 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Dec 2019 11:30:33 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id BB66FC00A3 for ; Sat, 7 Dec 2019 11:30:32 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.001 X-Spam-Level: * X-Spam-Status: No, score=1.001 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_REPLY=1, HTML_MESSAGE=0.2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id f5SgM92sfFBk for ; Sat, 7 Dec 2019 11:30:31 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::e2b; helo=mail-vs1-xe2b.google.com; envelope-from=yajiedesign@gmail.com; receiver= Received: from mail-vs1-xe2b.google.com (mail-vs1-xe2b.google.com [IPv6:2607:f8b0:4864:20::e2b]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 8558D7DD7F for ; Sat, 7 Dec 2019 11:30:30 +0000 (UTC) Received: by mail-vs1-xe2b.google.com with SMTP id g15so7024453vsf.1 for ; Sat, 07 Dec 2019 03:30:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=mYvC/eskxjtF3B1rtqY64mEiqGuMPskslJvWPWqJtq0=; b=FSMM946z4QH35pV3JXGEvV+iy17WnQzhs0eq3jfI1z6WNZhrP9x2hYIkcAP5SyxzR3 vwdOPMxkzKwzF7FRSycUoiOOJT+MBDfse8dAdMTc5qM3m1SE0lmlHbFWPHIsjVKJj+aa jzM1wjSSNpPJKduT4plmSeP9ISd1CNFqdV5iEYSI64yJCduuyX4cfzLGFusdDCUoyyAN IzMixA/igrHIBy5hGvTgbADI1vWfdSIYilJ+qmpBn5S4OMqVxHnQEjZDIZUycyS6OB74 N1Gct5dl/vrnnKJJrlbodkWYe1rti/RKhK69MdWKdig1BXOygJkfq39qfNxUebv1DaIO ujvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=mYvC/eskxjtF3B1rtqY64mEiqGuMPskslJvWPWqJtq0=; b=uf7Z/1wuqa7hwuAxYUELxYndR32hSAK9iDEum3i7r3WRN7dDgH76xi5Mln397sJooX NUSZt+WgDHA/9u0Eb44a830BM2c7FqujM+mla0FQb0YHK3/8ppITr2JTmAZQJ3d1VBFa 5ZKXJVetwDuCBn7eaxrm91wwfgCZxkrDeTHg0ehBvvgzyd/beDxB93yM1PW8LS5t6eEk nqJsoqH9xUHX+HIIHcTHsUPtmVXJWluSwJuORWxp9ETKRvgmcntezU/KTSD/+jmurWHb iGmEGdZux6JFGiVEsvq8bQ8EoLnJFg8EOsm+hl9+ZaZ7bz+M1Goh1gjkrWu6h4SiaYkm RYBQ== X-Gm-Message-State: APjAAAVax24BBdXe/FFulGwJkkaSgmzQUQZW3fy+U4bCUCwp/Pafg39V QH09uNbLMzU+X/+I8w2dGpkMCYxxHsfNuxVSYqWubWunfUc= X-Google-Smtp-Source: APXvYqwbEYaTMPbh/Xe4XytY8iEDpSIT5X/P3zMfNxbMeXp3v8n7PrEgufBP+F4IfNv+UY6RE6LpT6M7rT3E9Rhy5ig= X-Received: by 2002:a67:d81e:: with SMTP id e30mr13873021vsj.107.1575718222665; Sat, 07 Dec 2019 03:30:22 -0800 (PST) MIME-Version: 1.0 References: <665b3029-af98-4b67-892d-3d8af2d7794c@email.android.com> In-Reply-To: From: shiwen hu Date: Sat, 7 Dec 2019 19:30:07 +0800 Message-ID: Subject: Re: Can upgrade windows CI cmake? To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="000000000000ed9ccd05991b7c8d" --000000000000ed9ccd05991b7c8d Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable i test 3.12.2 3.13.3 3.14.2 3.15.5 shiwen hu =E4=BA=8E2019=E5=B9=B412=E6=9C=887=E6=97= =A5=E5=91=A8=E5=85=AD =E4=B8=8B=E5=8D=887:28=E5=86=99=E9=81=93=EF=BC=9A > yes. > > Lausen, Leonard =E4=BA=8E2019=E5=B9=B412=E6= =9C=887=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8B=E5=8D=887:20=E5=86=99=E9=81=93= =EF=BC=9A > >> Do you mean starting 3.15.5 it works fine? >> The image you attached doesn't display on my end. >> >> On Dec 7, 2019 19:12, shiwen hu wrote: >> [image.png] >> >> I tested these versions. until 3.15.5 is working fine. >> >> shiwen hu > >> =E4=BA=8E2019=E5=B9=B412=E6=9C=887=E6=97=A5=E5=91=A8=E5=85=AD =E4=B8=8B= =E5=8D=881:24=E5=86=99=E9=81=93=EF=BC=9A >> Now, other problems are solved by modifying CMakeLists.txt.but The >> command line is too long problem must update cmake.However I don't know >> which minimum version fixed the problem.I try to do some tests to find o= ut >> the minimum version. >> >> Pedro Larroy > pedro.larroy.lists@gmail.com>> =E4=BA=8E2019=E5=B9=B412=E6=9C=887=E6=97= =A5=E5=91=A8=E5=85=AD =E4=B8=8A=E5=8D=883:52=E5=86=99=E9=81=93=EF=BC=9A >> CMake shipped with ubuntu has issues when compiling with CUDA on GPU >> instances. I wouldn't recommend anything older than 3.12 for Linux GPU >> >> >> https://github.com/apache/incubator-mxnet/blob/master/ci/docker/install/= ubuntu_core.sh#L63 >> >> I don't know about windows CMake version but would make sense to require= a >> newer version. >> >> On Thu, Dec 5, 2019 at 7:26 PM Lausen, Leonard > > >> wrote: >> >> > Currently we declare cmake_minimum_required(VERSION 3.0.2) >> > >> > I'm in favor of updating our CMake requirement. The main question may = be >> > what >> > new version to pick as minimum requirement. >> > >> > In general, there is the guideline >> > >> > > You really should at least use a version of CMake that came out afte= r >> > your >> > > compiler, since it needs to know compiler flags, etc, for that >> version. >> > And, >> > > since CMake will dumb itself down to the minimum required version in >> your >> > > CMake file, installing a new CMake, even system wide, is pretty safe= . >> You >> > > should at least install it locally. It's easy (1-2 lines in many >> cases), >> > and >> > > you'll find that 5 minutes of work will save you hundreds of lines a= nd >> > hours >> > > of CMakeLists.txt writing, and will be much easier to maintain in th= e >> > long >> > > run. >> > https://cliutils.gitlab.io/modern-cmake/ >> > >> > https://cliutils.gitlab.io/modern-cmake/chapters/intro/newcmake.html >> > gives a >> > short overview of all the improvements made to CMake over the past 6 >> years. >> > >> > It's easy for users to upgrade their cmake version with pip: >> > pip install --upgrade --user cmake >> > Thus it wouldn't be overly problematic to rely on a very recent versio= n >> of >> > cmake, if indeed it's required. >> > >> > Nevertheless, if an earlier version fixes the problems, let's rather >> pick >> > that >> > one. Did you confirm which version is required to fix the problem? >> > >> > For now you could try if the CMake version shipped in the oldest >> supported >> > Ubuntu LTS release (Ubuntu 16.04) is fixing your problem (CMake 3.5)? = If >> > not, >> > please test if CMake version shipped in Ubuntu 18.04 (CMake 3.10) fixe= s >> > your >> > issue. >> > >> > Thanks >> > Leonard >> > >> > On Fri, 2019-12-06 at 08:45 +0800, shiwen hu wrote: >> > > i am send a pr https://github.com/apache/incubator-mxnet/pull/16980 >> to >> > > change windows build system.but now ci cmake version seems to be a >> bug. >> > > can't to compile.can upgrade to 3.16.0? >> > >> >> --000000000000ed9ccd05991b7c8d--