mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Wall <mjw...@gmail.com>
Subject Re: [VOTE] Release Apache MXNet (incubating) 1.5.1.rc0
Date Sat, 21 Sep 2019 18:26:02 GMT
Tao,

I started reviewing and then saw you close the vote.  I have finished my
review, so when you open up to the IPMC I'll post my +1.

Thanks

Mike

On Sat, Sep 21, 2019 at 10:39 AM Tao Lv <taolv@apache.org> wrote:

> Hi Mike,
> May I have your opinion? I'm going to count the vote now. Thanks!
>
> Hi Marco,
> Thanks for your input. We indeed fixed several license issues in this patch
> release but still have to leave over the license issue of cub and mklml to
> the next minor release.
>
> -tao
>
> On Sat, Sep 21, 2019 at 12:04 AM Marco de Abreu <marco.g.abreu@gmail.com>
> wrote:
>
> > We only need a mentors vote on general, but it certainly would be
> > appreciated especially considering the licensing issues we're constantly
> > encountering. One part of graduation is having a number of releases that
> > went without issues.
> >
> > -Marco
> >
> > Tao Lv <taolv@apache.org> schrieb am Fr., 20. Sep. 2019, 17:10:
> >
> > > Sure. Really appreciate your help, Mike.
> > >
> > > -tao
> > >
> > > On Fri, Sep 20, 2019 at 10:48 PM Michael Wall <mjwall@apache.org>
> wrote:
> > >
> > > > Tao,
> > > >
> > > > I can take a look tonight if you want to wait.
> > > >
> > > > Mike
> > > >
> > > > On Fri, Sep 20, 2019 at 10:45 AM Tao Lv <taolv@apache.org> wrote:
> > > >
> > > > > Thank you all for the support!
> > > > >
> > > > > One question, do we need mentor's vote here?
> > > > >
> > > > > Thanks,
> > > > > -tao
> > > > >
> > > > > On Fri, Sep 20, 2019 at 10:25 PM Carin Meier <carinmeier@gmail.com
> >
> > > > wrote:
> > > > >
> > > > > > +1 built and tested the Clojure package
> > > > > >
> > > > > > On Fri, Sep 20, 2019 at 12:08 AM Srivastava, Rohit Kumar <
> > > > > > srivastava.141@buckeyemail.osu.edu> wrote:
> > > > > >
> > > > > > > +1
> > > > > > > build mxnet from source with large tensor support. Ran
tests
> only
> > > for
> > > > > > > large array. All passed !
> > > > > > >
> > > > > > > ´╗┐On 9/19/19, 2:58 PM, "Lai Wei" <royweilai@gmail.com>
wrote:
> > > > > > >
> > > > > > >     +1
> > > > > > >
> > > > > > >     build from source on GPU and tested with gluon estimator
> and
> > > > latest
> > > > > > >     keras-mxnet.
> > > > > > >
> > > > > > >
> > > > > > >     Best Regards
> > > > > > >
> > > > > > >     Lai
> > > > > > >
> > > > > > >
> > > > > > >     On Thu, Sep 19, 2019 at 1:02 PM sandeep krishnamurthy
<
> > > > > > >     sandeep.krishna98@gmail.com> wrote:
> > > > > > >
> > > > > > >     > Thank you Tao for leading this and all the community
> > members
> > > > for
> > > > > > > helping in
> > > > > > >     > this release.
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > +1
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > -[Y] Are release files in correct location?
> > > > > > >     >
> > > > > > >     > -[Y] Do release files have the word incubating
in their
> > name?
> > > > > > >     >
> > > > > > >     > -[Y] Are the digital signature and hashes correct?
> > > > > > >     >
> > > > > > >     > -[Y] Does DISCLAIMER file exist?
> > > > > > >     >
> > > > > > >     > -[Y] Do LICENSE and NOTICE files exists?
> > > > > > >     >
> > > > > > >     > -[Y] Is the LICENSE and NOTICE text correct?
> > > > > > >     >
> > > > > > >     > -[Y] Is the NOTICE year correct?
> > > > > > >     >
> > > > > > >     > -[Y] Un-included software dependencies are not
mentioned
> in
> > > > > LICENSE
> > > > > > > or
> > > > > > >     > NOTICE?
> > > > > > >     >
> > > > > > >     > -[Y] License information is not mentioned in NOTICE?
> > > > > > >     >
> > > > > > >     > Is there any 3rd party code contained inside the
release?
> > If
> > > > so:
> > > > > > >     >
> > > > > > >     > -[N] Does the software have a compatible license?
> > > > > > >     >
> > > > > > >     > -[Y] Are all software licenses mentioned in LICENSE?
> > > > > > >     >
> > > > > > >     > -[Y] Is the full text of the licenses (or pointers
to it)
> > in
> > > > > > LICENSE?
> > > > > > >     >
> > > > > > >     > Is any of this code Apache licensed? Do they have
NOTICE
> > > files?
> > > > > If
> > > > > > > so:
> > > > > > >     >
> > > > > > >     > -[Y] Have relevant parts of those NOTICE files
been added
> > to
> > > > this
> > > > > > > NOTICE
> > > > > > >     >
> > > > > > >     > file?
> > > > > > >     >
> > > > > > >     > -[Y] Do all source files have ASF headers?
> > > > > > >     >
> > > > > > >     > -[Y] Do the contents of the release match with
what's
> > tagged
> > > in
> > > > > > > version
> > > > > > >     > control?
> > > > > > >     >
> > > > > > >     > -[N] Are there any unexpected binary files in
the
> release?
> > > > > > >     >
> > > > > > >     > -[Y] Can you compile from source? Are the instruction
> > clear?
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > Except the license issue mentioned in this Github
issue -
> > > > > > >     > https://github.com/apache/incubator-mxnet/issues/15542
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > I was able to build from source on GPU(p3.2x EC2
> instance)
> > > and
> > > > > run
> > > > > > >     > opperf-operator
> > > > > > >     > benchmark utilit
> > > > > > >     > <
> > > > > > >
> > > >
> https://github.com/apache/incubator-mxnet/tree/master/benchmark/opperf
> > > > > >y
> > > > > > >     > successfully
> > > > > > >     > with no regression compared to v1.5.0.
> > > > > > >     >
> > > > > > >     >
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > On Thu, Sep 19, 2019 at 11:51 AM Anirudh Subramanian
<
> > > > > > >     > anirudh2290@gmail.com>
> > > > > > >     > wrote:
> > > > > > >     >
> > > > > > >     > > +1
> > > > > > >     > >
> > > > > > >     > > Build from source with cmake and ran unittest
for gluon
> > and
> > > > > amp.
> > > > > > >     > >
> > > > > > >     > > Noticed that test_sync_batchnorm fails on
p3.8xlarge
> > > (hidden
> > > > by
> > > > > > > the CI
> > > > > > >     > > because passes on machines with 1 or 2 gpus).
> > > > > > >     > > I have opened an issue for the same
> > > > > > >     > > https://github.com/apache/incubator-mxnet/issues/16214
> > > > though
> > > > > I
> > > > > > > think
> > > > > > >     > its
> > > > > > >     > > not a blocker for this release.
> > > > > > >     > >
> > > > > > >     > > Anirudh
> > > > > > >     > >
> > > > > > >     > > On Thu, Sep 19, 2019 at 11:28 AM Chaitanya
Bapat <
> > > > > > > chai.bapat@gmail.com>
> > > > > > >     > > wrote:
> > > > > > >     > >
> > > > > > >     > > > +1
> > > > > > >     > > >
> > > > > > >     > > > Correctly built for GPU, CPU on Ubuntu
14.01 (10.1
> Cuda
> > > for
> > > > > > GPU)
> > > > > > >     > > > Ran image classification (resnet50+cifar10)
> > > > > > >     > > > Ran Operator Performance (opperf)
> > > > > > >     > > >
> > > > > > >     > > > On Thu, 19 Sep 2019 at 02:12, Tao Lv
<
> taolv@apache.org
> > >
> > > > > wrote:
> > > > > > >     > > >
> > > > > > >     > > > > Hi community,
> > > > > > >     > > > >
> > > > > > >     > > > > Friendly reminder: it is less than
1.5 days
> > remaining,
> > > so
> > > > > > > please take
> > > > > > >     > > > your
> > > > > > >     > > > > time to verify and vote.
> > > > > > >     > > > >
> > > > > > >     > > > > Thanks,
> > > > > > >     > > > > -tao
> > > > > > >     > > > >
> > > > > > >     > > > > On Thu, Sep 19, 2019 at 3:06 PM
Lin Yuan <
> > > > > > apeforest@gmail.com>
> > > > > > >     > wrote:
> > > > > > >     > > > >
> > > > > > >     > > > > > +1
> > > > > > >     > > > > > Tested Horovod on GPU
> > > > > > >     > > > > >
> > > > > > >     > > > > > On Wed, Sep 18, 2019 at 6:16
AM Zhao, Patric <
> > > > > > >     > patric.zhao@intel.com>
> > > > > > >     > > > > > wrote:
> > > > > > >     > > > > >
> > > > > > >     > > > > > > +1
> > > > > > >     > > > > > >
> > > > > > >     > > > > > > Tested MKLDNN backend
and everything looks
> great.
> > > > > > >     > > > > > >
> > > > > > >     > > > > > > > -----Original Message-----
> > > > > > >     > > > > > > > From: Qing Lan <lanking520@live.com>
> > > > > > >     > > > > > > > Sent: Wednesday,
September 18, 2019 2:20 AM
> > > > > > >     > > > > > > > To: dev@mxnet.incubator.apache.org
> > > > > > >     > > > > > > > Subject: Re: [VOTE]
Release Apache MXNet
> > > > (incubating)
> > > > > > > 1.5.1.rc0
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > +1 for Scala/Java
test. Passed all tests for
> > > > CPU/GPU
> > > > > > > build.
> > > > > > >     > > > > > > > Also tested build
from source with static
> > build.
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > Thanks,
> > > > > > >     > > > > > > > Qing
> > > > > > >     > > > > > > > ________________________________
> > > > > > >     > > > > > > > From: Tao Lv <taolv@apache.org>
> > > > > > >     > > > > > > > Sent: Tuesday, September
17, 2019 14:14
> > > > > > >     > > > > > > > To: dev@mxnet.incubator.apache.org
<
> > > > > > >     > > dev@mxnet.incubator.apache.org
> > > > > > >     > > > >
> > > > > > >     > > > > > > > Subject: [VOTE]
Release Apache MXNet
> > (incubating)
> > > > > > > 1.5.1.rc0
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > Dear MXNet community,
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > This is the 3-day
vote to release Apache
> MXNet
> > > > > > > (incubating)
> > > > > > >     > > version
> > > > > > >     > > > > > > 1.5.1.
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > Voting on dev@ will
start September 17,
> > 12:00pm
> > > > > (PST)
> > > > > > > and
> > > > > > >     > close
> > > > > > >     > > > on
> > > > > > >     > > > > > > > September 20, 12:00pm
(PST).
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > 1) Link to release
notes:
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > >
> > > > > > >     >
> > > > > > >
> > > >
> https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Notes
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > 2) Link to release
candidate:
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     >
> > > > https://github.com/apache/incubator-mxnet/releases/tag/1.5.1.rc0
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > 3) Link to source
and signatures on Apache
> dist
> > > > > server:
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > >
> > > > > >
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.5.1.rc0/
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > Please remember
to TEST first before voting
> > > > > > accordingly:
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > +1 = approve
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > +0 = no opinion
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > -1 = disapprove
(provide reason)
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > Thanks,
> > > > > > >     > > > > > > >
> > > > > > >     > > > > > > > -tao
> > > > > > >     > > > > > >
> > > > > > >     > > > > >
> > > > > > >     > > > >
> > > > > > >     > > >
> > > > > > >     > > >
> > > > > > >     > > > --
> > > > > > >     > > > *Chaitanya Prakash Bapat*
> > > > > > >     > > > *+1 (973) 953-6299*
> > > > > > >     > > >
> > > > > > >     > > > [image: https://www.linkedin.com//in/chaibapat25]
> > > > > > >     > > > <https://github.com/ChaiBapchya>[image:
> > > > > > >     > > https://www.facebook.com/chaibapat
> > > > > > >     > > > ]
> > > > > > >     > > > <https://www.facebook.com/chaibapchya>[image:
> > > > > > >     > > > https://twitter.com/ChaiBapchya] <
> > > > > > > https://twitter.com/ChaiBapchya
> > > > > > >     > > >[image:
> > > > > > >     > > > https://www.linkedin.com//in/chaibapat25]
> > > > > > >     > > > <https://www.linkedin.com//in/chaibapchya/>
> > > > > > >     > > >
> > > > > > >     > >
> > > > > > >     >
> > > > > > >     >
> > > > > > >     > --
> > > > > > >     > Sandeep Krishnamurthy
> > > > > > >     >
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message