From dev-return-6571-archive-asf-public=cust-asf.ponee.io@mxnet.incubator.apache.org Mon Aug 26 23:25:13 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 8EE2F180645 for ; Tue, 27 Aug 2019 01:25:13 +0200 (CEST) Received: (qmail 27888 invoked by uid 500); 26 Aug 2019 23:25:12 -0000 Mailing-List: contact dev-help@mxnet.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@mxnet.incubator.apache.org Delivered-To: mailing list dev@mxnet.incubator.apache.org Received: (qmail 27874 invoked by uid 99); 26 Aug 2019 23:25:12 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 26 Aug 2019 23:25:12 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id CD24FC098E for ; Mon, 26 Aug 2019 23:25:11 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.801 X-Spam-Level: * X-Spam-Status: No, score=1.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=2, KAM_SHORT=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id MJr98vQEj215 for ; Mon, 26 Aug 2019 23:25:08 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::22f; helo=mail-lj1-x22f.google.com; envelope-from=pedro.larroy.lists@gmail.com; receiver= Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 1F4B17DD38 for ; Mon, 26 Aug 2019 23:25:08 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id f9so16612152ljc.13 for ; Mon, 26 Aug 2019 16:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vwHVo/k8gW0gkrtTKr9EKqRLbsQtq5dlkcYG+5qMa8c=; b=javtB2iuAf7HVARIC2WMJQczblx7tkcM+Bxtx8fAuLG+N+3BCj318cHaZcS79YKELN 7QVP2WP9XiXLVTkGCIjXtWbCmqgrvdfggZeH24wl6zBVD/e/j6QlBBG5CCs4cwGDdFVi h/8OnSbUIKgC+wXDkNoGrDv3jlw3JvntGcE9rtP9R5CoSoHAonIvO2dg/uzIHTEi0tWz 095LcO5ODFYiZmjCiHbEx9m6YHqF1TIqHXsMnjt2tRscT/jdka14YvZX92SRXYLQoVs3 C2j4isJ8bmUm1t9ITJU+Wm5KCYQr/Mv/r6GsoYCfUaJBaLZXIq89zfylo/5l4JDKBaFj KXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=vwHVo/k8gW0gkrtTKr9EKqRLbsQtq5dlkcYG+5qMa8c=; b=AsxB/dGa0NULAE+NP9H11hATX/IzJ2XxFlhQXARQmzUkp+mmmB+wF4zXOpPlMPEf94 TdpqdsBVhPDNe/PaihLN7Ciaf7mgjqRUFC2Wgi5tjuWKgVni7zdNGgSRG1VLnR7w0pky tB/wsqReGISB+VP4ElaI1XEoK1v6gIJpNyx0aAALNShnoqnkmJDLcmofEJl1kypj5W/u N7vaPXyi8f7tHusyuoYZLvbkTovHDGkj67z/xkqSQtm0VDgmUc6MvN/RVnOQhIhZQM32 iWqOxrfF2YVBsduVZVS6C8Hon6h+sBJqiHnqLwxQgB75ySmliyhNbCoLgZ6fqUxb0CsD Hs4g== X-Gm-Message-State: APjAAAWVit1x4KwxpAKPZ/UMfm+AABMctuE3a//gdO9t/Qj3SFOhhDhl tzBI1JanMRmRgDEh5b4UGrWK7xApeXtFXxUy3Es0xLdO3uI= X-Google-Smtp-Source: APXvYqz2MHuHeecVpciiT6PpCdQaLJjIbFfkbN3lalhCPXgA5Qu0Z4PWvr41wGZ6r/rbtytjcfHq/XfSLPo/5C4LnS4= X-Received: by 2002:a05:651c:1105:: with SMTP id d5mr11860823ljo.161.1566861900758; Mon, 26 Aug 2019 16:25:00 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pedro Larroy Date: Mon, 26 Aug 2019 16:24:49 -0700 Message-ID: Subject: Re: [Discussion] MXNet 1.5.1 release To: dev@mxnet.incubator.apache.org Content-Type: multipart/alternative; boundary="00000000000001c12e05910d7760" --00000000000001c12e05910d7760 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable There's a fix that I did which seems to still produce crashes in 1.5 for some users, which I got notice today and is fixed in master. Might be useful to put in 1.5.1: https://github.com/apache/incubator-mxnet/pull/15762 ? Pedro. On Tue, Aug 20, 2019 at 7:49 AM Tao Lv wrote: > Hi dev, > > Here is an update for the 1.5.1 patch release. > > 1. Thanks for the effort from whole community, we have cherry picked a > bunch of fixes to v1.5.x branch. So far, the branch looks healthy: > > http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/NightlyT= estsForBinaries/activity/ > 2. https://github.com/apache/incubator-mxnet/pull/15803 cannot pass the > CI; > 3. I hope julia folks can take a look at the back porting for > https://github.com/apache/incubator-mxnet/pull/15609 and > https://github.com/apache/incubator-mxnet/pull/15608 - do we still need > them? > 4. License issue of cub and pybind is still not fixed. We also has a > license issue of a cat image in julia examples. > https://github.com/apache/incubator-mxnet/issues/15542 > 5. Still no progress for the sidebar issue: > https://github.com/apache/incubator-mxnet/issues/15200 > 6. There is a GPU OOM issue in 1.5.0 release and already root caused by > Lin: > > https://github.com/apache/incubator-mxnet/issues/15703#issuecomment-52278= 0492 > . > We need decide whether we want to get it fixed in the 1.5.1 patch release= . > > Please find details in > > https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Plan+and+= Status > . > > Thanks, > -tao > > On Mon, Aug 12, 2019 at 9:57 PM Zhao, Patric > wrote: > > > Thanks for the explanation, Marco & Tao. Sounds great! > > > > > -----Original Message----- > > > From: Tao Lv > > > Sent: Monday, August 12, 2019 9:54 PM > > > To: dev@mxnet.incubator.apache.org > > > Subject: Re: [Discussion] MXNet 1.5.1 release > > > > > > > Regarding the open issue, is there default code owner/maintainer? I= f > > > > so, he/she will be the right people to look into the issue. > > > > https://github.com/apache/incubator-mxnet/blob/master/CODEOWNERS > > > > > > > > > > I have no idea. But the CODEOWNERS is used to receive change > > notificaitons, > > > not actually indicates the maintainer of a piece of code. > > > > > > Do we have regularly build, run, functionality and performance testin= g > > for > > > > this release? > > > > > > > > > As Marco mentioned, build, run and functionality of v1.5.x branch are > > tracked > > > automatically by the CI for each cherry pick pull request and the > > nightly tests > > > here: > > > http://jenkins.mxnet-ci.amazon- > > > ml.com/blue/organizations/jenkins/NightlyTestsForBinaries/activity. > > > I see it's healthy so far. > > > > > > For performance, Shufan will track CPU performance with his test suit= e > > and > > > send out the report once the branch is frozen. I'm not sure if there > are > > any > > > other performance tests. > > > > > > On Mon, Aug 12, 2019 at 9:36 PM Marco de Abreu > > > > > > wrote: > > > > > > > Hi Patric, > > > > > > > > CI should automatically pick up the branch and validate it as usual= . > > > > > > > > Best regards, > > > > Marco > > > > > > > > Zhao, Patric schrieb am Mo., 12. Aug. 2019, > > 15:22: > > > > > > > > > It's great works, Tao =F0=9F=98=8A > > > > > > > > > > Regarding the open issue, is there default code owner/maintainer? > If > > > > > so, he/she will be the right people to look into the issue. > > > > > https://github.com/apache/incubator- > > > mxnet/blob/master/CODEOWNERS > > > > > > > > > > Do we have regularly build, run, functionality and performance > > > > > testing > > > > for > > > > > this release? > > > > > > > > > > Thanks, > > > > > > > > > > --Patric > > > > > > > > > > > -----Original Message----- > > > > > > From: Tao Lv > > > > > > Sent: Monday, August 12, 2019 8:59 PM > > > > > > To: dev@mxnet.incubator.apache.org > > > > > > Subject: Re: [Discussion] MXNet 1.5.1 release > > > > > > > > > > > > Update: > > > > > > > > > > > > We're cherry picking fixes from the master to the v1.5.x branch= . > > > > > > Some > > > > of > > > > > > them are already merged. Please find details on the cwiki page: > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Pl > > > > > > an+a > > > > > > nd+Status > > > > > > > > > > > > > > > > > > There are still 3 opens: > > > > > > 1. Nightly test failure on CI ( > > > > > > https://github.com/apache/incubator-mxnet/issues/15374): The > issue > > > > > > is > > > > > still > > > > > > open. I'm wondering if it has been fixed or not. If not, is the= re > > > > anyone > > > > > > working on it? > > > > > > 2. Broken Sidebar on website API for master and 1.5.0 ( > > > > > > https://github.com/apache/incubator-mxnet/issues/15200): I don'= t > > > > > > see > > > > any > > > > > > progress on this issue? Do we still want to include it into 1.5= .1 > > > > > > patch > > > > > release? > > > > > > 3. License issues need to be fixed before 1.6 release ( > > > > > > https://github.com/apache/incubator-mxnet/issues/15542): > Currently > > > > > > the license issue for code and images is partially fixed on the > > > > > > master > > > > > branch and > > > > > > will be picked to v1.5.x soon. MKLML license issue is pushed ou= t > > > > > > to 1.6 release. But license issue for cub and pybind is still > open. > > > > > > > > > > > > Let me know if you any suggestion. Thanks for your support! > > > > > > > > > > > > -tao > > > > > > > > > > > > > > > > > > On Wed, Aug 7, 2019 at 11:03 PM Tao Lv wrote= : > > > > > > > > > > > > > > > > > > > > Update: > > > > > > > > > > > > > > Thanks to wkcn's report, Issue #15774 [1] and the fix #15751 > [2] > > > > > > > are added to the scope of 1.5.1 patch release. > > > > > > > For issue #15703 [3], I'm still waiting from the response fro= m > > > > > > > the reporter. > > > > > > > Issue #15431 [4] was closed as false positive report. > > > > > > > I also included several MKL-DNN backend issues reported by > mxnet > > > > users > > > > > > > and downstream projects. They are already fixed on the master > > > branch. > > > > > > > > > > > > > > Please kindly check the full list of issues need be included = in > > > > > > > the > > > > > > > 1.5.1 patch release: > > > > > > > > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Pl > > > > > > an+a > > > > > > > nd+Status > > > > > > > > > > > > > > For issues which are already fixed on the master branch, we > will > > > > start > > > > > > > to cherry pick the fix commit to the v1.5.x branch. For issue= s > > > > > > > which are still open, we will start to track the fix process. > > > > > > > > > > > > > > Thanks for your great support. Let me know if you have any > > > > > > > questions or concerns. > > > > > > > > > > > > > > -tao > > > > > > > > > > > > > > [1] https://github.com/apache/incubator-mxnet/issues/15774 > > > > > > > [2] https://github.com/apache/incubator-mxnet/pull/15751 > > > > > > > [3] https://github.com/apache/incubator-mxnet/issues/15703 > > > > > > > [4] https://github.com/apache/incubator-mxnet/issues/15431 > > > > > > > > > > > > > > > > > > > > > On Tue, Aug 6, 2019 at 2:04 PM Tao Lv > wrote: > > > > > > > > > > > > > >> > > > > > > >> Per Sam's proposal [1], Issue #15737 [2] and the fix [3] are > > > > > > >> added > > > > to > > > > > > >> the scope of 1.5.1 patch release. > > > > > > >> > > > > > > >> A friendly reminder: the issue proposing will be closed befo= re > > > > > > >> 11pm > > > > > > >> 8/7 CST (8am 8/7 PST). After that, we will start to cherry > pick > > > > fixes > > > > > > >> to the v1.5.x branch. > > > > > > >> > > > > > > >> > > > > > > >> [1] > > > > > > >> https://github.com/apache/incubator- > > > > > > mxnet/issues/15613#issuecomment-5 > > > > > > >> 18430120 [2] > > > > > > >> https://github.com/apache/incubator-mxnet/issues/15737 > > > > > > >> [3] https://github.com/apache/incubator-mxnet/pull/15692 > > > > > > >> > > > > > > >> On Thu, Aug 1, 2019 at 4:24 PM Tao Lv > wrote: > > > > > > >> > > > > > > >>> Hi Sandeep/Lai, > > > > > > >>> > > > > > > >>> Thank you for the prompt response! > > > > > > >>> > > > > > > >>> https://github.com/apache/incubator-mxnet/issues/15200 is > > > > > > >>> added > > > > to > > > > > > >>> the list to track the sidebar issue. > > > > > > >>> > > > > > > >>> On Thu, Aug 1, 2019 at 7:54 AM sandeep krishnamurthy < > > > > > > >>> sandeep.krishna98@gmail.com> wrote: > > > > > > >>> > > > > > > >>>> Thank you Tao and Shufan. > > > > > > >>>> Sidebar missing bug in API documentation is inconvenience > for > > > > > > >>>> the > > > > > user. > > > > > > >>>> It > > > > > > >>>> would great if we can fix it with 1.5.1 > > > > > > >>>> > > > > > > >>>> On Wed, Jul 31, 2019, 10:14 AM Lai Wei > > > > > wrote: > > > > > > >>>> > > > > > > >>>> > Hi Tao, > > > > > > >>>> > > > > > > > >>>> > Thank you so much for driving it. Currently nightly tes= t > > > > > > >>>> > on > > > > > > >>>> tutorials are > > > > > > >>>> > failing and it need to be fixed. [3] I have updated the > > > > > > >>>> > issue[1] and cwiki.[2] > > > > > > >>>> > > > > > > > >>>> > [1] > https://github.com/apache/incubator-mxnet/issues/15613 > > > > > > >>>> > [2] > > > > > > >>>> > > > > > > > >>>> > > > > > > > >>>> > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Pl > > > > > > a > > > > > > >>>> n+and+Status > > > > > > >>>> > [3] > https://github.com/apache/incubator-mxnet/issues/15374 > > > > > > >>>> > > > > > > > >>>> > Best Regards > > > > > > >>>> > > > > > > > >>>> > Lai > > > > > > >>>> > > > > > > > >>>> > > > > > > > >>>> > On Wed, Jul 31, 2019 at 8:04 AM Tao Lv > > > > wrote: > > > > > > >>>> > > > > > > > >>>> > > Hi community, > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > Thanks for the initiative from Sam (samskalicky@github > ), > > > > > > >>>> > > we already > > > > > > >>>> > have a > > > > > > >>>> > > discussion thread [1] on github about the defects and > > > > > > >>>> > > bugs exposed > > > > > > >>>> in the > > > > > > >>>> > > 1.5.0 release. > > > > > > >>>> > > > > > > > > >>>> > > Shufan (juliusshufan@github) and I (TaoLv@github) woul= d > > > > > > >>>> > > like > > > > to > > > > > > >>>> manage > > > > > > >>>> > the > > > > > > >>>> > > release of 1.5.1. This will be our first debut on the > > > > > > >>>> > > release > > > > > > >>>> process, > > > > > > >>>> > your > > > > > > >>>> > > comments are always valuable. > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > Per the SemVer 2.0 [2], MXNet 1.5.1 will be a patch > > > > > > >>>> > > release which > > > > > > >>>> > contains > > > > > > >>>> > > backwards-compatible fixes only. > > > > > > >>>> > > > > > > > > >>>> > > I have created a page on cwiki [3] to track the releas= e > > > > process > > > > > > >>>> > > and > > > > > > >>>> moved > > > > > > >>>> > > the issues and PRs mentioned in the github discussion > > > > > > >>>> > > thread > > > > to > > > > > > >>>> > > the > > > > > > >>>> page. > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > Here I would like to ask the community to: > > > > > > >>>> > > > > > > > > >>>> > > (1) Raise any other defect or regression you identifie= d > > > > > > >>>> > > in the > > > > > > >>>> > > 1.5.0 release. Please file a github issue for it and > note > > > > > > >>>> > > the issue > > > > > > >>>> number in > > > > > > >>>> > > this thread; > > > > > > >>>> > > > > > > > > >>>> > > (2) Please comment with one sentence for why you think > > > > > > >>>> > > the issue is critical and must have in the 1.5.1 > release; > > > > > > >>>> > > > > > > > > >>>> > > (3) If the issue is already fixed on master branch or > > > > > > >>>> > > already have > > > > > > >>>> a PR > > > > > > >>>> > > WIP, please also note the fix commit id or PR number; > > > > > > >>>> > > > > > > > > >>>> > > (4) If the issue is still open and there is no PR WIP, > > > > > > >>>> > > please > > > > > > >>>> indicate > > > > > > >>>> > > whether you'd be willing to help it out; > > > > > > >>>> > > > > > > > > >>>> > > (5) Feel free to comment if any other suggestion for t= he > > > > > release. > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > I suggest to keep this thread open for one week to > > > > > > >>>> > > collect enough information and proposals before we > decide > > > > > > >>>> > > the timeline for the > > > > > > >>>> release. > > > > > > >>>> > So > > > > > > >>>> > > your timely response will be highly appreciated! > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > PS: Sorry to say that even as a committer, this is the > > > > > > >>>> > > first time > > > > > > >>>> for me > > > > > > >>>> > to > > > > > > >>>> > > manage a release. So it would be great if an experienc= ed > > > > > > >>>> > > committer > > > > > > >>>> can > > > > > > >>>> > help > > > > > > >>>> > > to guide the process. > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > -tao > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > [1] > > > > > > >>>> > > https://github.com/apache/incubator-mxnet/issues/15613 > > > > > > >>>> > > > > > > > > >>>> > > [2] https://semver.org/ > > > > > > >>>> > > > > > > > > >>>> > > [3] > > > > > > >>>> > > > > > > > > >>>> > > > > > > > > >>>> > > > > > > > >>>> > > > > > > > https://cwiki.apache.org/confluence/display/MXNET/1.5.1+Release+Pl > > > > > > a > > > > > > >>>> n+and+Status > > > > > > >>>> > > > > > > > > >>>> > > > > > > > >>>> > > > > > > >>> > > > > > > > > > > > > --00000000000001c12e05910d7760--