mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco de Abreu <marcoab...@apache.org>
Subject Disabling, circumventing and altering CI checks
Date Sat, 24 Aug 2019 08:01:53 GMT
Hello,

recently I have noticed a trend of CI checks being disabled, circumvented
or altered as part of a Pull Request. While I understand that these systems
might decline your PR, they execute checks and enforce standards that the
community has agreed on. The reason for these standards is not to give
contributors a hard time but instead to improve the maintainability,
compatibility and stability of our code base.

I acknowledge that there might have been a few issues recently that
resulted in an increased rate of false errors and I agree that this is not
ideal. But none the less, I'd like to encourage everybody to think about
the long-term impact of tampering with these systems.

Since I prefer to not call out names, I will keep this email generic. But a
few examples of what such a problematic change could look like include:
- Changing Jenkinsfiles
- Changing Dockerfiles
- Changing runtime functions
- Disabling linting or adding exclusions
- Adding additional preprocessor statements that avoid that codepath from
being checked by CI
- Disabling tests or making them conditional to avoid execution by CI

While I understand that new contributors might not be that used to the dos
and donts of a software project, I'd like to remind the committers of this
project to think in the best interest of the project and adhere to
engineering best practices. While I understand that there might be external
factors that create the urge to take these shortcuts, it's the committers
responsibility to ensure that they don't make their way into the codebase
or get remedied as soon as possible.

Thanks for your understanding.

Best regards,
Marco

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message