mxnet-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Junru Shao <junrushao1...@gmail.com>
Subject Re: [VOTE] Release Apache MXNet (incubating) version 1.4.1.rc0
Date Sat, 04 May 2019 06:38:10 GMT
Hi Anirudh,

Thanks for reporting this!

I verified on my EC2 machine for the second time. It perfectly builds with
your commands. It is a bit weird...I noticed that there is a subtle
difference that my ninja progress bar is like "[xxx/506]", while yours is
"[xxx/488]". I am not sure if there is anything different between our
settings.

My understanding is that cmake should work because it is tested in our CI
system under "ci/jenkins/incubator-mxnet" (
http://jenkins.mxnet-ci.amazon-ml.com/blue/organizations/jenkins/incubator-mxnet/detail/v1.4.x/201/pipeline
).

It will be much appreciated if someone could help confirm whether cmake
works on their side.

Thanks,
Junru


On Fri, May 3, 2019 at 9:43 PM Anirudh Subramanian <anirudh2290@gmail.com>
wrote:

> Hi Junru,
>
> I am on v1.4.x , and my dmlc-core commit is this one :
>
> https://github.com/dmlc/dmlc-core/tree/0a0e8addf92e1287fd7a25c6314016b8c0138dee
>
> Anirudh
>
> On Fri, May 3, 2019 at 8:30 PM Junru Shao <junrushao1994@gmail.com> wrote:
>
> > Hey Anirudh,
> >
> > Although the vote has been closed, I am very interested in digging into
> > this issue.
> >
> > I build on my EC2 machine using your instructions, and it seems that
> > everything is working fine...
> >
> > Then, I noticed that your issue seems to be related to unittests in
> > dmlc-core, not in mxnet. Could you kindly check the submodule git hash?
> > Also, could you check if you are testing on v1.4.x branch?
> >
> > Thanks,
> > Junru
> >
> >
> >
> > On Fri, May 3, 2019 at 4:33 PM Anirudh Subramanian <
> anirudh2290@gmail.com>
> > wrote:
> >
> > > -1 (binding)
> > >
> > > Is the cmake build failing for the 1.4.1 release tag ? Is this a known
> > > issue ?
> > >
> > > Did the following:
> > >
> > > cd build && cmake VERBOSE=1 -DUSE_CUDA=ON -DUSE_CUDNN=ON
> -DUSE_OPENMP=ON
> > > -DCMAKE_BUILD_TYPE=Debug -DUSE_DIST_KVSTORE=0 -DUSE_OPENCV=1
> > > -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda -DCUDNN_ROOT=/usr/local/cuda
> > > -DUSE_MKLDNN=1 -DUSE_MKL_IF_AVAILABLE=1 -DUSE_MKLML_MKL=1 -DUSE_ASAN=0
> > > -GNinja -DUSE_OPERATOR_TUNING=1 -DUSE_CPP_PACKAGE=0
> -DCUDA_ARCH_NAME=Auto
> > > .. && ninja -v
> > >
> > > [272/488] : && /usr/bin/c++   -Wall -Wno-unknown-pragmas -fPIC -g -O0
> > > -msse2 -std=c++11 -fopenmp -g  -pthread
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_lockfree.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_param.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_parser.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_array_view.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_any.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_config.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_serializer.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer_exc_handling.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_inputsplit.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_logging.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_json.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_optional.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_main.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_env.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_thread_group.cc.o
> > > -o 3rdparty/dmlc-core/test/unittest/dmlc_unit_tests  -rdynamic
> > > lib/libgtestd.a 3rdparty/dmlc-core/libdmlc.a -lpthread && :
> > > FAILED: : && /usr/bin/c++   -Wall -Wno-unknown-pragmas -fPIC -g -O0
> > -msse2
> > > -std=c++11 -fopenmp -g  -pthread
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_lockfree.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_param.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_parser.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_array_view.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_any.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_config.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_serializer.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_threaditer_exc_handling.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_inputsplit.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_logging.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_json.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_optional.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_main.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_env.cc.o
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_thread_group.cc.o
> > > -o 3rdparty/dmlc-core/test/unittest/dmlc_unit_tests  -rdynamic
> > > lib/libgtestd.a 3rdparty/dmlc-core/libdmlc.a -lpthread && :
> > >
> > >
> >
> 3rdparty/dmlc-core/test/unittest/CMakeFiles/dmlc_unit_tests.dir/unittest_logging.cc.o:
> > > In function `Logging_basics_Test::TestBody()':
> > >
> > >
> >
> /home/ubuntu/experimentals/master_mxnet/build/../3rdparty/dmlc-core/test/unittest/unittest_logging.cc:19:
> > > undefined reference to `testing::internal::DeathTest::Create(char
> const*,
> > > testing::internal::RE const*, char const*, int,
> > > testing::internal::DeathTest**)'
> > > collect2: error: ld returned 1 exit status
> > >
> > > Anirudh
> > >
> > > On Fri, May 3, 2019 at 8:04 AM kellen sunderland <
> > > kellen.sunderland@gmail.com> wrote:
> > >
> > > > No problem Damien, glad to have you helping us validating the
> release.
> > > > Just wanted to make suer we have enough votes to pass the general
> vote
> > > (the
> > > > next release step) and with Sheng I think we should.
> > > >
> > > > On Fri, May 3, 2019 at 7:52 AM Damien Stanton <
> > damien.stanton@gmail.com>
> > > > wrote:
> > > >
> > > > > Ah, I misunderstood the binding/non-binding distinction. I am not
a
> > > PPMC
> > > > > member, so my vote is non-binding.
> > > > >
> > > > > Best,
> > > > > Damien
> > > > >
> > > > > On Fri, May 3, 2019 at 3:19 AM kellen sunderland <
> > > > > kellen.sunderland@gmail.com> wrote:
> > > > >
> > > > > > Hi Junru could you give a quick summary of the binding /
> > non-binding
> > > > > votes.
> > > > > >
> > > > > > Damien just want to confirm, are you a member of the PPMC for
> > MXNet?
> > > > > > Usually committers or community members (like most of us) are
> > > > encouraged
> > > > > to
> > > > > > test and vote, but technically count as non-binding for releases.
> > > > > >
> > > > > > Sheng can we assume you're +1 on the release?
> > > > > >
> > > > > > On Fri, May 3, 2019 at 12:09 AM Junru Shao <
> > junrushao1994@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi folks,
> > > > > > >
> > > > > > > So far we have collected enough binding votes. Thank you
guys
> for
> > > the
> > > > > > hard
> > > > > > > work testing the release!
> > > > > > >
> > > > > > > The vote on dev@ is closed on May 02 23:59:59 (PST). Next,
we
> > are
> > > > > going
> > > > > > to
> > > > > > > vote for the Apache MXNet (incubating) release 1.4.1 on
> general@
> > > > > > tomorrow,
> > > > > > > which starts on May 3 2019, 23:59:59 PST, and ends on May
07
> > 2019,
> > > > > > 23:59:59
> > > > > > > PST.
> > > > > > >
> > > > > > > Best,
> > > > > > > Junru
> > > > > > >
> > > > > > > On Thu, May 2, 2019 at 11:29 PM Aston Zhang <
> > astonlzhang@gmail.com
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > +1 (non-binding)
> > > > > > > >
> > > > > > > > Passed all the code at zh.d2l.ai
> > > > > > > >
> > > > > > > > On Thu, May 2, 2019 at 1:46 PM Joshua Z. Zhang <
> > > > cheungchih@gmail.com
> > > > > >
> > > > > > > > wrote:
> > > > > > > >
> > > > > > > > > +1 (non-binding)
> > > > > > > > >
> > > > > > > > > Build from source with cuda/cudnn.
> > > > > > > > >
> > > > > > > > > - All tests passed
> > > > > > > > > - GluonCV unittest scripts passed
> > > > > > > > > - GluonCV training scripts passed
> > > > > > > > > - No issue with python multiprocessing
> > > > > > > > >
> > > > > > > > > Best,
> > > > > > > > > Zhi
> > > > > > > > > > On May 2, 2019, at 11:34 AM, kellen sunderland
<
> > > > > > > > > kellen.sunderland@gmail.com> wrote:
> > > > > > > > > >
> > > > > > > > > > +1 (non-binding)
> > > > > > > > > >
> > > > > > > > > > I checked TRT integration builds and tests
pass.
> > > > > > > > > > MD5s
> > > > > > > > > > Sigs look good.
> > > > > > > > > >
> > > > > > > > > > -Kellen
> > > > > > > > > >
> > > > > > > > > > On Thu, May 2, 2019 at 10:51 AM Damien Stanton
<
> > > > > > > > damien.stanton@gmail.com
> > > > > > > > > >
> > > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > >> +1 (binding)
> > > > > > > > > >>
> > > > > > > > > >> Built from source / Scala / Clojure.
All tests pass. The
> > > only
> > > > > > issue
> > > > > > > of
> > > > > > > > > >> minor note: The macOS build guide indicates
a directive
> > > `brew
> > > > > > > install
> > > > > > > > > >> opencv` however this installs OpenCV
4, which is
> currently
> > > > > > > > incompatible
> > > > > > > > > >> with mxnet and causes a failed build.
The guide should
> > > specify
> > > > > > `brew
> > > > > > > > > >> install opencv@3` until/if version 4
is supported.
> > > > > > > > > >>
> > > > > > > > > >> Best,
> > > > > > > > > >> Damien
> > > > > > > > > >>
> > > > > > > > > >> On Thu, May 2, 2019 at 12:53 PM Lai
Wei <
> > > royweilai@gmail.com>
> > > > > > > wrote:
> > > > > > > > > >>
> > > > > > > > > >>> +1
> > > > > > > > > >>>
> > > > > > > > > >>> Built from source and tested keras-mxnet
working fine.
> > > > > > > > > >>>
> > > > > > > > > >>> Best Regards
> > > > > > > > > >>>
> > > > > > > > > >>> Lai
> > > > > > > > > >>>
> > > > > > > > > >>>
> > > > > > > > > >>> On Wed, May 1, 2019 at 4:22 PM Carin
Meier <
> > > > > carinmeier@gmail.com
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > >>>
> > > > > > > > > >>>> + 1 (binding)
> > > > > > > > > >>>>
> > > > > > > > > >>>> Built Scala/ Clojure and ran
tests
> > > > > > > > > >>>>
> > > > > > > > > >>>> On Wed, May 1, 2019 at 7:06
PM Aaron Markham <
> > > > > > > > > >> aaron.s.markham@gmail.com>
> > > > > > > > > >>>> wrote:
> > > > > > > > > >>>>
> > > > > > > > > >>>>> Make that +1 (non-binding)
> > > > > > > > > >>>>>
> > > > > > > > > >>>>> On Wed, May 1, 2019 at 3:42
PM Aaron Markham <
> > > > > > > > > >>> aaron.s.markham@gmail.com>
> > > > > > > > > >>>>> wrote:
> > > > > > > > > >>>>>>
> > > > > > > > > >>>>>> +1 (binding)
> > > > > > > > > >>>>>>
> > > > > > > > > >>>>>> * Built with GPU and
tested the first part of the
> ssd
> > > > > example.
> > > > > > > > > >>>>>> * Built with GPU / cross-compiled
to arm8 for
> Jetson.
> > > > > > > > > >>>>>> * Built Scala/Java on
top of the cross-compiled arm8
> > > (ran
> > > > > into
> > > > > > > > > >>> trouble
> > > > > > > > > >>>>>> here, but I think this
is not popular enough yet to
> > > derail
> > > > > > > things,
> > > > > > > > > >>>>>> plus there are workarounds)
> > > > > > > > > >>>>>> * Built on CPU instance
and tested docs.
> > > > > > > > > >>>>>>
> > > http://34.201.8.176/versions/1.4.1/api/python/io/io.html
> > > > > > > > > >>>>>> I don't see anything
specific being different in
> this
> > > > patch
> > > > > > for
> > > > > > > > > >> docs,
> > > > > > > > > >>>>>> so hard to tell if there's
an issue. I'll assume not
> > > given
> > > > > the
> > > > > > > > > >>>>>> successful generation
of the API docs.
> > > > > > > > > >>>>>>
> > > > > > > > > >>>>>>
> > > > > > > > > >>>>>> On Wed, May 1, 2019
at 1:28 PM Pedro Larroy
> > > > > > > > > >>>>>> <pedro.larroy.lists@gmail.com>
wrote:
> > > > > > > > > >>>>>>>
> > > > > > > > > >>>>>>> +1 (non-binding)
> > > > > > > > > >>>>>>>
> > > > > > > > > >>>>>>> Tried CPU build
+ C++ tests + 714 Python unit tests
> > in
> > > > > 605s.
> > > > > > > > > >>>>>>> ARMv7 build + small
unit test in QEMU + ARMv8
> builds.
> > > > > > > > > >>>>>>>
> > > > > > > > > >>>>>>> Thanks. Regards
> > > > > > > > > >>>>>>>
> > > > > > > > > >>>>>>> Pedro.
> > > > > > > > > >>>>>>>
> > > > > > > > > >>>>>>> On Wed, May 1, 2019
at 10:41 AM Qing Lan <
> > > > > > lanking520@live.com>
> > > > > > > > > >>>> wrote:
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> +1 (binding)
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> build from source
works for OSX and Ubuntu CPU
> > > > > > > > > >>>>>>>> Scala build/test
successfully with Dynamic link
> and
> > > > static
> > > > > > > > > >> link.
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> Thanks,
> > > > > > > > > >>>>>>>> Qing
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> ________________________________
> > > > > > > > > >>>>>>>> From: Sheng
Zha <zhasheng@apache.org>
> > > > > > > > > >>>>>>>> Sent: Wednesday,
May 1, 2019 13:14
> > > > > > > > > >>>>>>>> To: dev@mxnet.apache.org
> > > > > > > > > >>>>>>>> Subject: Re:
[VOTE] Release Apache MXNet
> > (incubating)
> > > > > > version
> > > > > > > > > >>>>> 1.4.1.rc0
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> Hi all,
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> Reminder that
the vote for 1.4.1 release is still
> > > > ongoing.
> > > > > > If
> > > > > > > > > >> you
> > > > > > > > > >>>>> can, please help out. Thank
you.
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> -sz
> > > > > > > > > >>>>>>>>
> > > > > > > > > >>>>>>>> On 2019/04/30
06:51:45, Junru Shao <
> > > > > junrushao1994@gmail.com
> > > > > > >
> > > > > > > > > >>>> wrote:
> > > > > > > > > >>>>>>>>> Dear MXNet
community,
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>>>>> This is
the 3-day vote to release Apache MXNet
> > > > > (incubating)
> > > > > > > > > >>>>> version v1.4.1.
> > > > > > > > > >>>>>>>>> The voting
on dev@ list will start Apr 29
> 23:59:59
> > > > (PST)
> > > > > > and
> > > > > > > > > >>>>> close on May
> > > > > > > > > >>>>>>>>> 02 23:59:59.
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>>>>> Below are
links to
> > > > > > > > > >>>>>>>>> 1) Release
notes:
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>
> > > > > > > > > >>>>
> > > > > > > > > >>>
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.4.1+Release+Notes
> > > > > > > > > >>>>>>>>> .
> > > > > > > > > >>>>>>>>> 2) Release
Candidate:
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>
> > > > > https://github.com/apache/incubator-mxnet/releases/tag/1.4.1.rc0
> > > > > > > > > >>>> .
> > > > > > > > > >>>>>>>>> 3) Source
and signatures on Apache dist server:
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>
> > > > > >
> https://dist.apache.org/repos/dist/dev/incubator/mxnet/1.4.1.rc0/
> > > > > > > .
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>>>>> Please remember
to TEST first before voting
> > > > accordingly:
> > > > > > > > > >>>>>>>>> +1 = approve
> > > > > > > > > >>>>>>>>> +0 = no
opinion
> > > > > > > > > >>>>>>>>> -1 = disapprove
(provide reason)
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>>>>> Best regards,
> > > > > > > > > >>>>>>>>> Junru Shao
> > > > > > > > > >>>>>>>>>
> > > > > > > > > >>>>>
> > > > > > > > > >>>>
> > > > > > > > > >>>
> > > > > > > > > >>
> > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message